Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_dynamic_obstacle_avoidance_module): fix bitwiseOnBoolean warning #7636

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 24, 2024

Description

This is a fix based on cppcheck `bitwiseOnBoolean warning

planning/behavior_path_planner/autoware_behavior_path_dynamic_obstacle_avoidance_module/src/scene.cpp:1474:47: style: inconclusive: Boolean expression 'enable_lowpass_filter' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean]
    (prev_min_lat_avoid_to_offset.has_value() & enable_lowpass_filter)
                                              ^
planning/behavior_path_planner/autoware_behavior_path_dynamic_obstacle_avoidance_module/src/scene.cpp:1559:47: style: inconclusive: Boolean expression 'enable_lowpass_filter' is used in bitwise operation. Did you mean '&&'? [bitwiseOnBoolean]
    (prev_min_lat_avoid_to_offset.has_value() & enable_lowpass_filter)
                                              ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…twiseOnBoolean warning

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 24, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my... Thank you for the fix!

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.41%. Comparing base (507e3f4) to head (1cadf2a).
Report is 114 commits behind head on main.

Files Patch % Lines
...th_dynamic_obstacle_avoidance_module/src/scene.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7636       +/-   ##
==========================================
- Coverage   14.84%   8.41%    -6.44%     
==========================================
  Files        1999     229     -1770     
  Lines      139163   21720   -117443     
  Branches    43716    2806    -40910     
==========================================
- Hits        20661    1827    -18834     
+ Misses      95731   19620    -76111     
+ Partials    22771     273    -22498     
Flag Coverage Δ
differential 8.41% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 5bead38 into autowarefoundation:main Jun 24, 2024
38 of 40 checks passed
@veqcc veqcc deleted the fix_bitwise_on_boolean branch June 24, 2024 02:24
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…twiseOnBoolean warning (autowarefoundation#7636)

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…twiseOnBoolean warning (autowarefoundation#7636)

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…twiseOnBoolean warning (#7636)

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants