Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_goal_planner_module): fix lateral_offset related warnings #7624

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 22, 2024

Description

This is a fix based on cppcheck variableScope and unreadVariable warnings

planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_searcher.cpp:164:12: style: The scope of the variable 'lateral_offset' can be reduced. [variableScope]
    double lateral_offset = 0.0;
           ^
planning/behavior_path_planner/autoware_behavior_path_goal_planner_module/src/goal_searcher.cpp:164:27: style: Variable 'lateral_offset' is assigned a value that is never used. [unreadVariable]
    double lateral_offset = 0.0;
                          ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…elated warnings

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 22, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 22, 2024
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@kosuke55 kosuke55 enabled auto-merge (squash) June 22, 2024 08:41
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (507e3f4) to head (2e174a1).
Report is 101 commits behind head on main.

Files Patch % Lines
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7624       +/-   ##
==========================================
- Coverage   14.84%   0.00%   -14.85%     
==========================================
  Files        1999     243     -1756     
  Lines      139163   23168   -115995     
  Branches    43716    2951    -40765     
==========================================
- Hits        20661       0    -20661     
+ Misses      95731   23168    -72563     
+ Partials    22771       0    -22771     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 3900cbe into autowarefoundation:main Jun 22, 2024
38 of 40 checks passed
@veqcc veqcc deleted the fix_unread_variable branch June 22, 2024 10:54
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…elated warnings (autowarefoundation#7624)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…elated warnings (autowarefoundation#7624)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…elated warnings (#7624)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants