Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_camera_view_rviz_plugin): fix funcArgNamesDifferent warnings #7621

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 21, 2024

Description

This is a fix based on cppcheck funcArgNamesDifferent warnings

common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp:102:80: style: inconclusive: Function 'handleMouseEvent' argument 1 names different: declaration 'evt' definition 'event'. [funcArgNamesDifferent]
void BirdEyeViewController::handleMouseEvent(rviz_common::ViewportMouseEvent & event)
                                                                               ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.hpp:75:59: note: Function 'handleMouseEvent' argument 1 names different: declaration 'evt' definition 'event'.
  void handleMouseEvent(rviz_common::ViewportMouseEvent & evt) override;
                                                          ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp:102:80: note: Function 'handleMouseEvent' argument 1 names different: declaration 'evt' definition 'event'.
void BirdEyeViewController::handleMouseEvent(rviz_common::ViewportMouseEvent & event)
                                                                               ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp:231:47: style: inconclusive: Function 'move_camera' argument 1 names different: declaration 'x' definition 'dx'. [funcArgNamesDifferent]
void BirdEyeViewController::move_camera(float dx, float dy)
                                              ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.hpp:99:26: note: Function 'move_camera' argument 1 names different: declaration 'x' definition 'dx'.
  void move_camera(float x, float y);
                         ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp:231:47: note: Function 'move_camera' argument 1 names different: declaration 'x' definition 'dx'.
void BirdEyeViewController::move_camera(float dx, float dy)
                                              ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp:231:57: style: inconclusive: Function 'move_camera' argument 2 names different: declaration 'y' definition 'dy'. [funcArgNamesDifferent]
void BirdEyeViewController::move_camera(float dx, float dy)
                                                        ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.hpp:99:35: note: Function 'move_camera' argument 2 names different: declaration 'y' definition 'dy'.
  void move_camera(float x, float y);
                                  ^
common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp:231:57: note: Function 'move_camera' argument 2 names different: declaration 'y' definition 'dy'.
void BirdEyeViewController::move_camera(float dx, float dy)
                                                        ^
common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp:108:84: style: inconclusive: Function 'handleMouseEvent' argument 1 names different: declaration 'evt' definition 'event'. [funcArgNamesDifferent]
void ThirdPersonViewController::handleMouseEvent(rviz_common::ViewportMouseEvent & event)
                                                                                   ^
common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.hpp:71:59: note: Function 'handleMouseEvent' argument 1 names different: declaration 'evt' definition 'event'.
  void handleMouseEvent(rviz_common::ViewportMouseEvent & evt) override;
                                                          ^
common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp:108:84: note: Function 'handleMouseEvent' argument 1 names different: declaration 'evt' definition 'event'.
void ThirdPersonViewController::handleMouseEvent(rviz_common::ViewportMouseEvent & event)
                                                                                   ^

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc requested a review from Owen-Liuyuxuan June 21, 2024 11:25
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 21, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 21, 2024
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! LGTM

@veqcc veqcc merged commit 8b24d9b into autowarefoundation:main Jun 22, 2024
34 checks passed
@veqcc veqcc deleted the fix_arg_name branch June 22, 2024 05:32
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
autowarefoundation#7621)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
#7621)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants