chore(ci): change way to get modified files for cppcheck #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…ndation#7610) * chore(ci): change way to modified files for cppcheck Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * fix(ci): use correct base ref in cppcheck differential Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: remove typo Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* chore(ci): change way to modified files for cppcheck Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * fix(ci): use correct base ref in cppcheck differential Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore: remove typo Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to apply the knowledge gained from
autowarefoundation/get-modified-packagesaction's development to cppcheck workflow.autowarefoundation/autoware-github-actions#299
This PR fixes the issue where diffs could not be obtained correctly when the branch is not up-to-date.
Tests performed
when the branch is up-to-date
https://github.com/autowarefoundation/autoware.universe/actions/runs/9596328091/job/26462963086
when the branch is not up-to-date
https://github.com/autowarefoundation/autoware.universe/actions/runs/9596328104/job/26495780548#step:7:8
Effects on system behavior
Not applicable.
Interface changes
N/A
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.