Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(universe_utils/motion_utils)!: add autoware namespace #7594

Merged
merged 2 commits into from
Jun 20, 2024

refactor(motion_utils): add autoware namespace

56c575d
Select commit
Loading
Failed to load commit list.
Merged

refactor(universe_utils/motion_utils)!: add autoware namespace #7594

refactor(motion_utils): add autoware namespace
56c575d
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 19, 2024 in 3m 22s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 4 findings(s) 🚩

View detailed results in CodeScene

Absence of Expected Change Pattern

  • autoware.universe/planning/autoware_velocity_smoother/src/smoother/jerk_filtered_smoother.cpp is usually changed with: autoware.universe/planning/autoware_velocity_smoother/src/smoother/linf_pseudo_jerk_smoother.cpp

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method decisions.cpp: object_time_to_range
  • Complex Method scene_crosswalk.cpp: CrosswalkModule::checkStopForCrosswalkUsers
  • Complex Method shift_pull_out.cpp: ShiftPullOut::plan
  • Complex Method decisions.cpp: object_time_to_range

Annotations

Check notice on line 1 in common/autoware_motion_utils/src/resample/resample.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Function Size

The median function size increase from 51.5 to 52.5 LOC, threshold = 50.0. This file contains overly long functions, measured by their lines of code.

Check notice on line 1 in planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/drivable_area_expansion/static_drivable_area.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1448 to 1449, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1608 in planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/drivable_area_expansion/static_drivable_area.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Complex Method

postProcess already has high cyclomatic complexity, and now it increases in Lines of Code from 117 to 118. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/utils.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1292 to 1293, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check warning on line 139 in planning/behavior_path_planner/autoware_behavior_path_start_planner_module/src/shift_pull_out.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

ShiftPullOut::plan already has high cyclomatic complexity, and now it increases in Lines of Code from 79 to 80. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 418 in planning/behavior_velocity_planner/autoware_behavior_velocity_crosswalk_module/src/scene_crosswalk.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

CrosswalkModule::checkStopForCrosswalkUsers already has high cyclomatic complexity, and now it increases in Lines of Code from 86 to 87. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 444 in planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module/src/scene_intersection_occlusion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Complex Method

IntersectionModule::detectOcclusion already has high cyclomatic complexity, and now it increases in Lines of Code from 310 to 311. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 109 in planning/motion_velocity_planner/autoware_motion_velocity_out_of_lane_module/src/decisions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

object_time_to_range already has high cyclomatic complexity, and now it increases in Lines of Code from 85 to 86. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in planning/motion_velocity_planner/autoware_motion_velocity_out_of_lane_module/src/decisions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

object_time_to_range already has high cyclomatic complexity, and now it increases in Lines of Code from 85 to 86. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.