Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dynamic_obstacle_stop): move to motion_velocity_planner #7460

Merged
merged 8 commits into from
Jun 13, 2024
Merged

refactor(dynamic_obstacle_stop): move to motion_velocity_planner #7460

merged 8 commits into from
Jun 13, 2024

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jun 12, 2024 •
edited
Loading

Description

Move the dynamic_obstacle_stop module from behavior to motion planning.
Required launch PR: autowarefoundation/autoware_launch#1025

Tests performed

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/198096ac-c551-5cfd-b1ad-aa177a7b0e68?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 12, 2024
@maxime-clem maxime-clem mentioned this pull request Jun 12, 2024
Merged
4 tasks
@maxime-clem maxime-clem added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Jun 12, 2024
@github-actions GitHub Actions
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-7460/
Modified URLs:

@maxime-clem
mv folder
5954bc6 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
rename package in doc, codeowner, etc
8d40dde 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
update launch files
0b7c2a7 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
setup new module and namespace (build without main loop code)
27bdd96 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
fix launch param filepath
015e276 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
implement update_parameters
c87362d 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
update Path -> TrajectoryPoints and rename path->trajectory
f52ea10 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
fix plugin export, implement main loop
9134abe 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the refactor/dyn_obs_stop-move_to-motion_velocity_planner branch from da1160f to 9134abe Compare June 13, 2024 02:36
@maxime-clem maxime-clem merged commit 65665ce into autowarefoundation:main Jun 13, 2024
26 checks passed
@maxime-clem maxime-clem deleted the refactor/dyn_obs_stop-move_to-motion_velocity_planner branch June 13, 2024 08:04
@maxime-clem maxime-clem mentioned this pull request Jun 13, 2024
Closed
4 tasks
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@maxime-clem
refactor(dynamic_obstacle_stop): move to motion_velocity_planner (#7460)
cacaa8d 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@soblin soblin soblin approved these changes

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxime-clem @takayuki5168 @soblin