-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner_common): fix namespace of drivable_area_expansion #7444
Merged
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:refactor/drivable_area_expansion-autoware_namespace
Jun 12, 2024
Merged
refactor(behavior_path_planner_common): fix namespace of drivable_area_expansion #7444
maxime-clem
merged 2 commits into
autowarefoundation:main
from
maxime-clem:refactor/drivable_area_expansion-autoware_namespace
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayuki5168
approved these changes
Jun 11, 2024
youtalk
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hope this PR will solve the upstream problem https://github.com/autowarefoundation/autoware/actions/runs/9462193749/job/26064607799?pr=4853
4 tasks
35fab28
to
8d91c85
Compare
5 tasks
b607154
to
01c1b37
Compare
soblin
approved these changes
Jun 12, 2024
takayuki5168
approved these changes
Jun 12, 2024
satoshi-ota
approved these changes
Jun 12, 2024
kosuke55
approved these changes
Jun 12, 2024
rej55
approved these changes
Jun 12, 2024
zulfaqar-azmi-t4
approved these changes
Jun 12, 2024
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
e1e6fdb
to
90a1634
Compare
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…a_expansion (#7444) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change namespace from
drivable_area_expansion
toautoware::behavior_path_planner::drivable_area_expansion
.Tests performed
Psim
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.