Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fix state transition in lane change module #7436

Merged
merged 5 commits into from
Jun 13, 2024

Merge branch 'main' into fix/state_transition_lane_change

37884ce
Select commit
Loading
Failed to load commit list.
Merged

fix(lane_change): fix state transition in lane change module #7436

Merge branch 'main' into fix/state_transition_lane_change
37884ce
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jun 13, 2024 in 40s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method interface.cpp: LaneChangeInterface::canTransitFailureState

Annotations

Check warning on line 243 in planning/autoware_behavior_path_lane_change_module/src/interface.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

LaneChangeInterface::canTransitFailureState increases in cyclomatic complexity from 15 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis