Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_start_planner_module)!: prefix package and namespace with autoware #7352

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Jun 7, 2024

Description

Part of autowarefoundation/autoware#4569

Related links

Tests performed

PSIM

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jun 7, 2024
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
This reverts commit 8aeee42.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
This reverts commit 8cf69f8.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran force-pushed the add-autoware-prefix-to-start-planner branch from dc82f79 to d69dd5e Compare June 7, 2024 03:11
danielsanchezaran and others added 3 commits June 7, 2024 12:14
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@kyoichi-sugahara kyoichi-sugahara changed the title chore(start_planner): add autoware prefix to start planner refactor(start_planner): add autoware prefix to start planner Jun 7, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start_planner): add autoware prefix to start planner refactor(behavior_path_start_planner_module)!: prefix package and namespace with autoware Jun 7, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@danielsanchezaran danielsanchezaran merged commit 9c961a9 into autowarefoundation:main Jun 7, 2024
41 of 43 checks passed
@danielsanchezaran danielsanchezaran deleted the add-autoware-prefix-to-start-planner branch June 7, 2024 06:20
@kosuke55
Copy link
Contributor

this PR did not add autoware namespace

KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…espace with autoware (#7352)

* change folder names

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* change namespace

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add prefix in files

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add prefix to files outside the module

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add namespace to plugin

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* Revert "add namespace to plugin"

This reverts commit 8aeee42.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* Revert "change namespace"

This reverts commit 8cf69f8.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix doc

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix back doc

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants