Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image_projection_based_fusion): add copying input fields to output for segmentation_pointcloud_fusion #7224

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jun 3, 2024

Description

Tests performed

  • Confirmed by logging_simulator that the output of segmentation_pointcloud_fusion node has intensity field as input.
    Screenshot from 2024-06-03 09-57-18

Screenshot from 2024-06-03 09-57-33

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 3, 2024
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 3, 2024
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@badai-nguyen badai-nguyen enabled auto-merge (squash) June 5, 2024 12:34
@badai-nguyen badai-nguyen added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 18.37%. Comparing base (3d849e9) to head (44940c6).
Report is 157 commits behind head on main.

Files Patch % Lines
...fusion/src/segmentation_pointcloud_fusion/node.cpp 0.00% 21 Missing ⚠️
...sed_fusion/segmentation_pointcloud_fusion/node.hpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7224       +/-   ##
===========================================
+ Coverage   15.09%   18.37%    +3.27%     
===========================================
  Files        1967       18     -1949     
  Lines      135941     1350   -134591     
  Branches    42122      556    -41566     
===========================================
- Hits        20520      248    -20272     
+ Misses      92700     1011    -91689     
+ Partials    22721       91    -22630     
Flag Coverage Δ
differential 18.37% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen merged commit cae30eb into autowarefoundation:main Jun 6, 2024
41 of 45 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jun 6, 2024
…t for segmentation_pointcloud_fusion (autowarefoundation#7224)

* fix: copy input fields to output

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* style(pre-commit): autofix

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…t for segmentation_pointcloud_fusion (#7224)

* fix: copy input fields to output

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* style(pre-commit): autofix

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants