Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner)!: ignore to graze against unknwon objects #7177

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented May 30, 2024

Description

This PR provides a feature to ignore grazing against unknown objects, such as bushes.

Screencast from 2024年05月30日 19時07分47秒.webm
To create the demo movie, I set up that pedestrians are assumed as unknown.
The movie shows that no stop-planning takes place if the collision width is small enough against the pedestrian.

launch PR: autowarefoundation/autoware_launch#1009

Tests performed

psim and tier4 internal tests

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 30, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review May 30, 2024 11:19
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 30, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick change!

…r.param.yaml

Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
@yuki-takagi-66 yuki-takagi-66 merged commit 05e3071 into autowarefoundation:main May 31, 2024
20 of 22 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the cruise/ignore-to-graze-against-unknowns branch May 31, 2024 07:35
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ts (autowarefoundation#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jun 4, 2024
…ts (autowarefoundation#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jun 5, 2024
…ts (autowarefoundation#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…ts (autowarefoundation#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jun 10, 2024
…ts (autowarefoundation#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jun 10, 2024
…ts (autowarefoundation#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
@yuki-takagi-66 yuki-takagi-66 changed the title feat(obstacle_cruise_planner)!: ignore to garze against unknwon objects feat(obstacle_cruise_planner)!: ignore to graze against unknwon objects Jun 10, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jun 10, 2024
…ts (autowarefoundation#7177) (#1331)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jun 11, 2024
…ts (autowarefoundation#7177) (#1331)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
dai0912th pushed a commit to tier4/autoware.universe that referenced this pull request Jun 12, 2024
…ts (autowarefoundation#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ts (#7177)

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants