Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename avoidance package #7168

Merged
merged 8 commits into from
May 31, 2024
Merged

chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename avoidance package #7168

merged 8 commits into from
May 31, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 30, 2024 •
edited
Loading

Description

Rename modules:

  • behavior_path_avoidance_module -> autoware_behavior_path_static_obstacle_avoidance_module
  • behavior_path_dynamic_avoidance_module -> autoware_behavior_path_dynamic_obstacle_avoidance_module

Tests performed

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels May 30, 2024
@satoshi-ota satoshi-ota force-pushed the chore/rename-avoidance-package branch from 4aa8306 to 4aeb75e Compare May 30, 2024 05:35
This was referenced May 30, 2024
Merged
Merged
Merged
@satoshi-ota satoshi-ota marked this pull request as ready for review May 30, 2024 10:23
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 30, 2024
yuki-takagi-66
yuki-takagi-66 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much
LGTM
Perhaps the parameter file name should be changed as well, but I don't mind either way.

...autoware_behavior_path_dynamic_obstacle_avoidance_module/config/dynamic_avoidance.param.yaml Outdated Show resolved Hide resolved
@satoshi-ota
chore(autoware_behavior_path_static_obstacle_avoidance_module): renam…
10c07b4 
…e package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rena…
7acec3c 
…me package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
chore(tier4_planning_launch): update module name
cba866f 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
chore(rtc_interface): update module name
6245b76 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
chore(avoidance): update module param file name
ec309e9 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the chore/rename-avoidance-package branch from 67d2794 to ec309e9 Compare May 30, 2024 13:21
@satoshi-ota
chore(avoidance): update schema file name
df69e56 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
fix(AbLC): fix file name
14975cd 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
docs: update module name
b15cd3b 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota merged commit badf1f7 into autowarefoundation:main May 31, 2024
19 of 22 checks passed
@satoshi-ota satoshi-ota deleted the chore/rename-avoidance-package branch May 31, 2024 03:39
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@satoshi-ota @karishma1911
chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename …
1d489b0 
…avoidance package (autowarefoundation#7168)

* chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(tier4_planning_launch): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(rtc_interface): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update module param file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update schema file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(AbLC): fix file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
@satoshi-ota
chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename …
764b47e 
…avoidance package (autowarefoundation#7168)

* chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(tier4_planning_launch): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(rtc_interface): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update module param file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update schema file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(AbLC): fix file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
@satoshi-ota @a-maumau
chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename …
2b14bd2 
…avoidance package (autowarefoundation#7168)

* chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(tier4_planning_launch): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(rtc_interface): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update module param file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update schema file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(AbLC): fix file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@esteve esteve mentioned this pull request Jun 12, 2024
Open
@go-sakayori go-sakayori mentioned this pull request Jun 21, 2024
Merged
7 tasks
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
@satoshi-ota
chore(static_obstacle_avoidance, dynamic_obstacle_avoidance): rename …
f3d6c66 
…avoidance package (#7168)

* chore(autoware_behavior_path_static_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(autoware_behavior_path_dynamic_obstacle_avoidance_module): rename package and namespace

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(tier4_planning_launch): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(rtc_interface): update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update module param file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* chore(avoidance): update schema file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(AbLC): fix file name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs: update module name

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuki-takagi-66 yuki-takagi-66 yuki-takagi-66 approved these changes

@rej55 rej55 rej55 approved these changes

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran

@go-sakayori go-sakayori Awaiting requested review from go-sakayori

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshi-ota @rej55 @yuki-takagi-66