Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo_pose_projector): componentize GeoPoseProjector #7138

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 27, 2024

Description

Componentize the node in localization/geo_pose_projector.
(Add glog feature to localization/geo_pose_projector)

Also, log output is changed from "screen" to "both".

Tests performed

Confirmed that terminating the geo_pose_projector process will output logs to both the terminal and the log file.
Since it will not get launched from Autoware, use ros2 launch geo_pose_projector geo_pose_projector.launch.xml for testing.

1716798177.1595407 [geo_pose_projector_node-1] [INFO] [1716798177.158774220] [rclcpp]: signal_handler(signum=15)
1716798177.1604719 [geo_pose_projector_node-1] *** Aborted at 1716798177 (unix time) try "date -d @1716798177" if you are using GNU date ***
1716798177.1631484 [geo_pose_projector_node-1] PC: @                0x0 (unknown)
1716798177.1640441 [geo_pose_projector_node-1] *** SIGTERM (@0x3e800086304) received by PID 1264019 (TID 0x7fb54f29b680) from PID 549636; stack trace: ***
1716798177.1667609 [geo_pose_projector_node-1]     @     0x7fb54fb404d6 google::(anonymous namespace)::FailureSignalHandler()
1716798177.1678352 [geo_pose_projector_node-1]     @     0x7fb54fa19ded rclcpp::SignalHandler::signal_handler()
1716798177.1681249 [geo_pose_projector_node-1]     @     0x7fb54f042520 (unknown)
1716798177.1684601 [geo_pose_projector_node-1]     @     0x7fb54f091117 (unknown)
1716798177.1687515 [geo_pose_projector_node-1]     @     0x7fb54f093a41 pthread_cond_wait
1716798177.1690331 [geo_pose_projector_node-1]     @     0x7fb54ef16a8d ddsrt_cond_wait
1716798177.1692960 [geo_pose_projector_node-1]     @     0x7fb54ef16b55 ddsrt_cond_waituntil
1716798177.1695654 [geo_pose_projector_node-1]     @     0x7fb54eefd45d (unknown)
1716798177.1697586 [geo_pose_projector_node-1]     @     0x7fb54efb974f rmw_wait
1716798177.1701515 [geo_pose_projector_node-1]     @     0x7fb54f780848 rcl_wait
1716798177.1707375 [geo_pose_projector_node-1]     @     0x7fb54f9611b6 rclcpp::Executor::wait_for_work()
1716798177.1712554 [geo_pose_projector_node-1]     @     0x7fb54f9616d3 rclcpp::Executor::get_next_executable()
1716798177.1717589 [geo_pose_projector_node-1]     @     0x7fb54f965c81 rclcpp::executors::SingleThreadedExecutor::spin()
1716798177.1719007 [geo_pose_projector_node-1]     @     0x560b896a6486 main
1716798177.1720548 [geo_pose_projector_node-1]     @     0x7fb54f029d90 (unknown)
1716798177.1723087 [geo_pose_projector_node-1]     @     0x7fb54f029e40 __libc_start_main
1716798177.1723714 [geo_pose_projector_node-1]     @     0x560b896a6e35 _start
1716798177.1734738 [ERROR] [geo_pose_projector_node-1]: process has died ...

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

a-maumau added 3 commits May 27, 2024 17:25
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 27, 2024
@KYabuuchi KYabuuchi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 27, 2024
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that geo_pose_pojector_node prints the log when it is killed in logging_simulator.launch.xml 👏

Looks Good To Me 🙆‍♂️

@KYabuuchi KYabuuchi enabled auto-merge (squash) May 27, 2024 09:12
@KYabuuchi KYabuuchi merged commit f28a757 into autowarefoundation:main May 28, 2024
34 of 37 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…dation#7138)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…dation#7138)

* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau deleted the mau/feat/localization/geo_pose_projector branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* remove unusing main func file

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* mod to componentize and use glog

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* change log output from screen to both

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants