fix(ndt_scan_matcher): changed the type of timestamp from double to int in ndt diag #7128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
YamatoAndo
approved these changes
May 27, 2024
6744b1a
into
autowarefoundation:main
32 of 34 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…nt in ndt diag (autowarefoundation#7128) Changed the type of timestamp from double to int in ndt diag Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…nt in ndt diag (autowarefoundation#7128) Changed the type of timestamp from double to int in ndt diag Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…nt in ndt diag (#7128) Changed the type of timestamp from double to int in ndt diag Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ndt_scan_matcheroutputs timestamps asdoubleto/diagnostics.In diagnostics_module, this is converted to
stringbystd::to_string, so it has 6 decimal places and the last 3 digits are removed.To match other topics (like
pose_with_covariance), it is useful to keep the full timestamp. So, I fixed it.Tests performed
logging_simulator works well.
topic_time_stampis changed toint64_t.Effects on system behavior
There is no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.