Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tensorrt_yolox): add processing time and cyclic time debug topic #7126

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented May 27, 2024

Description

  • To add processing/cyclic time ms to tensorrt_yolox

Tests performed

  • Confirmed that the debug topics (processing_time_ms and cyclic_time_ms) have been added already.
    ( The result of running tensorrt_yolox with preprocess_on_gpu:=true on local notebook PC)

image

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 27, 2024
@badai-nguyen badai-nguyen requested a review from YoshiRi May 27, 2024 02:26
@badai-nguyen badai-nguyen added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels May 27, 2024
@dan-dnn
Copy link
Contributor

dan-dnn commented May 27, 2024

@badai-nguyen
Regarding performance evaluation, could you also specify the environment, such as the GPU and CPU?

@badai-nguyen
Copy link
Contributor Author

@badai-nguyen Regarding performance evaluation, could you also specify the environment, such as the GPU and CPU?

@dan-dnn Did you mean about the figure in Test peformance.
Since this PR is only for adding the debug topic and the test peformance is mainly to show that the desired topics are already appreared. Anyway, I updated the Test peformance to make clear that point.

@dan-dnn dan-dnn closed this May 27, 2024
@dan-dnn dan-dnn reopened this May 27, 2024
@badai-nguyen badai-nguyen merged commit cbaf62a into autowarefoundation:main May 27, 2024
58 of 65 checks passed
Comment on lines +32 to +39
{
stop_watch_ptr_ =
std::make_unique<tier4_autoware_utils::StopWatch<std::chrono::milliseconds>>();
debug_publisher_ =
std::make_unique<tier4_autoware_utils::DebugPublisher>(this, "tensorrt_yolox");
stop_watch_ptr_->tic("cyclic_time");
stop_watch_ptr_->tic("processing_time");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badai-nguyen
Sorry for the delay in my review. Let me confirm one point: Do you intend to enable this debug_publisher_ at all times? In my opinion, I would like to put a condition to enable/disable this kind of debug feature on actual deployment.

karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
autowarefoundation#7126)

fix: add processing time topic

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
autowarefoundation#7126)

fix: add processing time topic

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Jul 17, 2024
autowarefoundation#7126)

fix: add processing time topic

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
#7126)

fix: add processing time topic

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants