-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tensorrt_yolox): add processing time and cyclic time debug topic #7126
chore(tensorrt_yolox): add processing time and cyclic time debug topic #7126
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen |
@dan-dnn Did you mean about the figure in |
{ | ||
stop_watch_ptr_ = | ||
std::make_unique<tier4_autoware_utils::StopWatch<std::chrono::milliseconds>>(); | ||
debug_publisher_ = | ||
std::make_unique<tier4_autoware_utils::DebugPublisher>(this, "tensorrt_yolox"); | ||
stop_watch_ptr_->tic("cyclic_time"); | ||
stop_watch_ptr_->tic("processing_time"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@badai-nguyen
Sorry for the delay in my review. Let me confirm one point: Do you intend to enable this debug_publisher_
at all times? In my opinion, I would like to put a condition to enable/disable this kind of debug feature on actual deployment.
autowarefoundation#7126) fix: add processing time topic Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
autowarefoundation#7126) fix: add processing time topic Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
autowarefoundation#7126) fix: add processing time topic Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
#7126) fix: add processing time topic Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Description
Tests performed
processing_time_ms
andcyclic_time_ms
) have been added already.( The result of running tensorrt_yolox with
preprocess_on_gpu:=true
on local notebook PC)Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.