-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multi_object_tracker): revert mot node implementation to composable node components #7117
fix(multi_object_tracker): revert mot node implementation to composable node components #7117
Conversation
…ion (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
3a4a6cc
to
ab0020d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7117 +/- ##
==========================================
- Coverage 15.82% 15.75% -0.07%
==========================================
Files 1900 1906 +6
Lines 132416 132885 +469
Branches 43848 43822 -26
==========================================
- Hits 20953 20937 -16
- Misses 88362 88870 +508
+ Partials 23101 23078 -23
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…le node components (autowarefoundation#7117) * Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: follow executable naming rule Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update executable name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…le node components (autowarefoundation#7117) * Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: follow executable naming rule Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update executable name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…le node components (#7117) * Revert "chore(multi_object_tracker): change node and glog implementation (#6780)" This reverts commit 81c432e. Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: follow executable naming rule Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * fix: update executable name Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Description
By the Autoware guide, exporting a standalone node executable without composition is discouraged.
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#exporting-a-composable-node-component-executables
This PR reverts the previous change #6780 of node implementation
Tests performed
ps -efH|grep multi_object_tracker
kill -15 <pid>
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.