Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): revert mot node implementation to composable node components #7117

Merged

Conversation

technolojin
Copy link
Contributor

Description

By the Autoware guide, exporting a standalone node executable without composition is discouraged.
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#exporting-a-composable-node-component-executables

This PR reverts the previous change #6780 of node implementation

Tests performed

  1. Ran a logging replay simulator.
  2. for glog
  • find pid by ps -efH|grep multi_object_tracker
  • manually terminate kill -15 <pid>

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ion (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the feat/mot-revert-node-impl branch from 3a4a6cc to ab0020d Compare May 24, 2024 08:41
@technolojin technolojin self-assigned this May 24, 2024
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
@technolojin technolojin marked this pull request as ready for review May 24, 2024 08:49
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 15.75%. Comparing base (5145bb5) to head (50b312e).
Report is 15 commits behind head on main.

Files Patch % Lines
...i_object_tracker/src/multi_object_tracker_core.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7117      +/-   ##
==========================================
- Coverage   15.82%   15.75%   -0.07%     
==========================================
  Files        1900     1906       +6     
  Lines      132416   132885     +469     
  Branches    43848    43822      -26     
==========================================
- Hits        20953    20937      -16     
- Misses      88362    88870     +508     
+ Partials    23101    23078      -23     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.82% <ø> (+<0.01%) ⬆️ Carriedforward from 5145bb5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin changed the title fix(multi_object_tracker) revert mot node implementation to composable node components fix(multi_object_tracker): revert mot node implementation to composable node components May 27, 2024
@technolojin technolojin merged commit 9d71cce into autowarefoundation:main May 27, 2024
26 of 30 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…le node components (autowarefoundation#7117)

* Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: follow executable naming rule

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: update executable name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…le node components (autowarefoundation#7117)

* Revert "chore(multi_object_tracker): change node and glog implementation (autowarefoundation#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: follow executable naming rule

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: update executable name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…le node components (#7117)

* Revert "chore(multi_object_tracker): change node and glog implementation (#6780)"

This reverts commit 81c432e.

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: follow executable naming rule

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: update executable name

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin deleted the feat/mot-revert-node-impl branch July 26, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants