refactor(obstacle_cruise): refactor a function checkConsistency() #7105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takayuki5168
approved these changes
May 24, 2024
d5e691e
into
autowarefoundation:main
43 of 47 checks passed
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…towarefoundation#7105) refactor Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 5, 2024
…towarefoundation#7105) refactor Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 5, 2024
…towarefoundation#7105) refactor Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jun 7, 2024
…towarefoundation#7105) refactor Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
saka1-s
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 14, 2024
… abandon to stop (#1336) * feat(obstacle_cruise_planner): add calculation of obstacle distance to ego (autowarefoundation#6057) Add the arc length from the ego to the obstacle stop point to the stop_reasons topic. Signed-off-by: Ioannis Souflas <isouflas@gmail.com> * refactor(obstacle_cruise): refactor a function checkConsistency() (autowarefoundation#7105) refactor Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * add abandon function Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * fix lib include Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> --------- Signed-off-by: Ioannis Souflas <isouflas@gmail.com> Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Co-authored-by: Ioannis Souflas <isouflas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix incorrect comments and organize if-else structure
I guess this PR does not cause any behavior change.
Tests performed
psim and tier4 internal tests
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.