Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(behavior_path_planner_common): remove unnecessary angle calculation in OccupancyGridMapBasedDetector #7103

Merged
merged 1 commit into from
May 23, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 23, 2024

Description

Related links

https://github.com/orgs/autowarefoundation/discussions/4748

Tests performed

no need, just removed unnecessary calculation

Notes for reviewers

Interface changes

none

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…OccupancyGridMapBasedDetector

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 23, 2024
@soblin soblin changed the title perf(behavior_path_planner_common): unnecessary angle calculation in OccupancyGridMapBasedDetector perf(behavior_path_planner_common): remove unnecessary angle calculation in OccupancyGridMapBasedDetector May 23, 2024
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 23, 2024
@soblin soblin merged commit 3eed12c into autowarefoundation:main May 23, 2024
33 of 35 checks passed
@soblin soblin deleted the fix/occ-grid-based-detector branch May 23, 2024 12:00
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ion in OccupancyGridMapBasedDetector (autowarefoundation#7103)

perf(behavior_path_planner_common): unnecessary angle calculation in OccupancyGridMapBasedDetector

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…ion in OccupancyGridMapBasedDetector (autowarefoundation#7103)

perf(behavior_path_planner_common): unnecessary angle calculation in OccupancyGridMapBasedDetector

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
…ion in OccupancyGridMapBasedDetector (autowarefoundation#7103)

perf(behavior_path_planner_common): unnecessary angle calculation in OccupancyGridMapBasedDetector

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ion in OccupancyGridMapBasedDetector (#7103)

perf(behavior_path_planner_common): unnecessary angle calculation in OccupancyGridMapBasedDetector

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants