-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accel_brake_map_calibrator): fix accel_brake_map_calibrator not to output invalid maps #6992
fix(accel_brake_map_calibrator): fix accel_brake_map_calibrator not to output invalid maps #6992
Conversation
…o output invalid maps Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Another Case Input:
Output: (Before: invalid)
Output: (After: valid)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…o output invalid maps (autowarefoundation#6992) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
chore: backport autowarefoundation#6973 and autowarefoundation#6992
…o output invalid maps (autowarefoundation#6992) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
…o output invalid maps (autowarefoundation#6992) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Description
I have fixed accel_brake_map_calibrator not to output invalid maps.
(
In particular, in previous implementations, there were cases where an invalid map would be outputted when the values of adjacent elements in the map were very close. I have fixed this issue. )
Related links
(TIERIV Internal Link) https://tier4.atlassian.net/browse/RT0-31507
Tests performed
Before:
An accel_brake_map_calibrator output invalid accel_map.csv
Output:
After:
Even if an invalid accel_map is provided as input, the output of accel_brake_map_calibrator will be a valid file.
Input:
Output:
Notes for reviewers
Interface changes
none
ROS Topic Changes
none
ROS Parameter Changes
none
Effects on system behavior
accel_brake_map_calibrator becomes not to output invalid maps.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.