Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception_online_evaluator): add use_perception_online_evaluator option and disable it by default #6861

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Apr 22, 2024

Description

add use_perception_online_evaluator option and disable it by default.
this is because currently the computational costs is high.

Tests performed

psim with this option true and false

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Apr 22, 2024
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 22, 2024
@kosuke55 kosuke55 marked this pull request as ready for review April 22, 2024 08:46
…r option and disable it by default

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/disable_perception_online_evaluator branch from cb547f6 to 02a50a3 Compare April 22, 2024 08:49
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@shmpwk shmpwk enabled auto-merge (squash) April 22, 2024 12:37
@shmpwk shmpwk disabled auto-merge April 22, 2024 12:40
@shmpwk shmpwk merged commit 00db87d into autowarefoundation:main Apr 22, 2024
21 of 22 checks passed
@shmpwk shmpwk deleted the feat/disable_perception_online_evaluator branch April 22, 2024 12:40
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861) (#1271)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
badai-nguyen pushed a commit to tier4/autoware.universe that referenced this pull request May 9, 2024
…r option and disable it by default (autowarefoundation#6861)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…r option and disable it by default (autowarefoundation#6861)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants