-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perception_online_evaluator): add use_perception_online_evaluator option and disable it by default #6861
Merged
shmpwk
merged 1 commit into
autowarefoundation:main
from
tier4:feat/disable_perception_online_evaluator
Apr 22, 2024
Merged
feat(perception_online_evaluator): add use_perception_online_evaluator option and disable it by default #6861
shmpwk
merged 1 commit into
autowarefoundation:main
from
tier4:feat/disable_perception_online_evaluator
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r option and disable it by default Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
cb547f6
to
02a50a3
Compare
shmpwk
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
badai-nguyen
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
4 tasks
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861) (#1271) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
badai-nguyen
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 23, 2024
…r option and disable it by default (autowarefoundation#6861) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
badai-nguyen
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
May 9, 2024
…r option and disable it by default (autowarefoundation#6861) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…r option and disable it by default (autowarefoundation#6861) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add use_perception_online_evaluator option and disable it by default.
this is because currently the computational costs is high.
Tests performed
psim with this option true and false
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.