Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(pointcloud_preprocessor): prevent excessive log and speed up a bit #6843

Merged
merged 4 commits into from
Apr 18, 2024

remove redundant for loop and rclcpp::Time instantiation

87f02b9
Select commit
Loading
Failed to load commit list.
Merged

perf(pointcloud_preprocessor): prevent excessive log and speed up a bit #6843

remove redundant for loop and rclcpp::Time instantiation
87f02b9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Apr 18, 2024 in 39s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method distortion_corrector.cpp: DistortionCorrectorComponent::undistortPointCloud

Annotations

Check warning on line 326 in sensing/pointcloud_preprocessor/src/distortion_corrector/distortion_corrector.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

DistortionCorrectorComponent::undistortPointCloud increases in cyclomatic complexity from 21 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis