fix(distortion_correction_node): remove redundant code

[vividf]

Description

There is a for-loop and a while loop doing the same thing. Basically, when implementing the while loop, the contributor forgot to delete it.
https://github.com/autowarefoundation/autoware.universe/pull/2913/files

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[yukkysaito]

@vividf Since the code appears to be designed to improve performance, it is better to check the execution time impact.
related link : #2913

[kminoda]

Thank you for the PR 🙏

@yukkysaito My understanding is that this modification does not change any performance, simply increasing the readability of the code by removing "purely" redundant code, given that the following while loop does exactly the same thing as the for loop.

@vividf Would you confirm if the above argument is correct?

[vividf]

@kminoda
Yes, you are correct :)

@yukkysaito
In the PR, [#2913], you can also see that the author removed the for loop and added the while loop for optimization for twist. But for imu, only the while loop was added.
I also analyze the time difference (green: remove for-loop, red: original)

Below is the value of the above graph (100 samples)
Remove for-loop:
min: 5.1, max: 11.98, avg: 6.56

Original
min: 5.29, max: 11.95, avg: 6.88

The value average processing time is lower because the current implementation still uses the for-loop. By removing the for-loop and using the while loop that the author implemented it will decrease the time.

reference:
#(https://github.com/autowarefoundation/autoware.universe/pull/2913/files#:~:text=it_y%2C%20%2B%2Bit_z%2C%20%2B%2Bit_time_stamp)%20%7B-,for%20(%3B,%2B%2Btwist_it)%20%7B,-while%20(twist_it)

[kminoda]

LGTM

[badai-nguyen]

@vividf could you resolve conflict?

[vividf]

Due to the approval being late, another PR (#6843) also solved this.