Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blockage_diag): add dust diagnostic option param #6645

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 18, 2024

Description

Related link

Tests performed

  • Confirmed by logging_simulator that each blockage_diag node reflected the optional params correctly.
enable_dust_diag: false
publish_debug_image: false

image

enable_dust_diag: true
publish_debug_image: false

image

enable_dust_diag: false
publish_debug_image: true

image

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Mar 18, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen requested a review from 0x126 March 21, 2024 12:33
@badai-nguyen badai-nguyen marked this pull request as ready for review March 21, 2024 12:33
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (59f7031) to head (367c470).
Report is 88 commits behind head on main.

Files Patch % Lines
...cessor/src/blockage_diag/blockage_diag_nodelet.cpp 0.00% 81 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6645    +/-   ##
========================================
  Coverage   14.78%   14.78%            
========================================
  Files        1917     1917            
  Lines      132038   132991   +953     
  Branches    39228    39433   +205     
========================================
+ Hits        19523    19669   +146     
- Misses      90726    91483   +757     
- Partials    21789    21839    +50     
Flag Coverage Δ *Carryforward flag
differential 5.45% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 59f7031

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen
Copy link
Contributor Author

@kyoichi-sugahara Could I ask your review for this PR and the releated ones?

@kyoichi-sugahara
Copy link
Contributor

how about adding following callback?

  if (get_param(p, "publish_debug_image", publish_debug_image_)) {
    RCLCPP_DEBUG(get_logger(), "Setting new publish_debug_image_ to: %d.", publish_debug_image_);
  }
  if (get_param(p, "enable_dust_diag", enable_dust_diag_)) {
    RCLCPP_DEBUG(get_logger(), "Setting new enable_dust_diag_ to: %d.", enable_dust_diag_);
  }

@badai-nguyen
Copy link
Contributor Author

badai-nguyen commented Mar 26, 2024

@kyoichi-sugahara Thank you for your comment.
However, if we make publish_debug_image and enable_dust_diag to be able to change by callback, then

  1. debug image topics and blockage_diag/debug/ground_dust_ratio topics will be created but nothing to be published
    image

  2. Even enable_dust_diag=False, there will be many dust related diag validation will be created in rqt_runtime_monitor
    image
    That might make users confused.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@badai-nguyen badai-nguyen merged commit 37cd3f8 into autowarefoundation:main Mar 29, 2024
43 of 47 checks passed
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Mar 29, 2024
…ation#6645)

* fix: add dust diag option param

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add debug image publish option param

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ation#6645)

* fix: add dust diag option param

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add debug image publish option param

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: typo

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants