-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockage_diag): add dust diagnostic option param #6645
chore(blockage_diag): add dust diagnostic option param #6645
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6645 +/- ##
========================================
Coverage 14.78% 14.78%
========================================
Files 1917 1917
Lines 132038 132991 +953
Branches 39228 39433 +205
========================================
+ Hits 19523 19669 +146
- Misses 90726 91483 +757
- Partials 21789 21839 +50
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@kyoichi-sugahara Could I ask your review for this PR and the releated ones? |
how about adding following callback?
|
@kyoichi-sugahara Thank you for your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ation#6645) * fix: add dust diag option param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add debug image publish option param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: typo Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…ation#6645) * fix: add dust diag option param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add debug image publish option param Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: typo Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Description
Related link
Tests performed
logging_simulator
that eachblockage_diag
node reflected the optional params correctly.Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.