Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(out_of_lane): use bigger stop lines to cut predicted paths #6630

Merged

Conversation

maxime-clem
Copy link
Contributor

Description

Fixes an edge case with the feature to cut predicted paths at red traffic lights.
In some case the predicted path goes slightly around the stop line and it is not correctly cut.
With this PR, the stop line is made longer to avoid this edge case.

Tests performed

Psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 15, 2024
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (152b11e) to head (cbc4a5a).
Report is 24 commits behind head on main.

❗ Current head cbc4a5a differs from pull request most recent head 238a373. Consider uploading reports for the commit 238a373 to get more accurate results

Files Patch % Lines
...ut_of_lane_module/src/filter_predicted_objects.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6630      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1923     1923              
  Lines      132468   132471       +3     
  Branches    39363    39367       +4     
==========================================
  Hits        19586    19586              
- Misses      91032    91033       +1     
- Partials    21850    21852       +2     
Flag Coverage Δ *Carryforward flag
differential 21.26% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from 152b11e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem enabled auto-merge (squash) March 22, 2024 02:43
@maxime-clem maxime-clem merged commit 3a346c7 into autowarefoundation:main Mar 22, 2024
24 checks passed
@maxime-clem maxime-clem deleted the out_of_lane/bigger_stop_line branch March 22, 2024 04:26
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…arefoundation#6630)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Apr 8, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants