Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): add maker for stop reason #6579

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 9, 2024

Description

Added a text marker of "steering not converged" to easily notice that the ego keeps stopped since the steering control is not converged.
image
image

Disabled by default.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Mar 9, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review March 9, 2024 11:09
@takayuki5168 takayuki5168 requested a review from shmpwk March 9, 2024 11:10
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 9, 2024
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (888fec6) to head (aa23513).
Report is 21 commits behind head on main.

Files Patch % Lines
...nal_controller/src/pid_longitudinal_controller.cpp 30.00% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6579      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1917     1917              
  Lines      132012   132017       +5     
  Branches    39228    39227       -1     
==========================================
  Hits        19523    19523              
- Misses      90699    90702       +3     
- Partials    21790    21792       +2     
Flag Coverage Δ *Carryforward flag
differential 39.95% <30.00%> (?)
total 14.78% <ø> (-0.01%) ⬇️ Carriedforward from 9b5a372

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit b6cd8f4 into autowarefoundation:main Mar 13, 2024
22 of 25 checks passed
@takayuki5168 takayuki5168 deleted the feat/control-stop-reason-marker branch March 13, 2024 15:18
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Mar 14, 2024
…efoundation#6579)

* feat(pid_longitudinal_controller): add maker for stop reason

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Mar 15, 2024
…efoundation#6579)

* feat(pid_longitudinal_controller): add maker for stop reason

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…efoundation#6579)

* feat(pid_longitudinal_controller): add maker for stop reason

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…efoundation#6579)

* feat(pid_longitudinal_controller): add maker for stop reason

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* minor fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants