-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pid_longitudinal_controller): add maker for stop reason #6579
feat(pid_longitudinal_controller): add maker for stop reason #6579
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6579 +/- ##
==========================================
- Coverage 14.78% 14.78% -0.01%
==========================================
Files 1917 1917
Lines 132012 132017 +5
Branches 39228 39227 -1
==========================================
Hits 19523 19523
- Misses 90699 90702 +3
- Partials 21790 21792 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…efoundation#6579) * feat(pid_longitudinal_controller): add maker for stop reason Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * minor fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…efoundation#6579) * feat(pid_longitudinal_controller): add maker for stop reason Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * minor fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…efoundation#6579) * feat(pid_longitudinal_controller): add maker for stop reason Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * minor fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
…efoundation#6579) * feat(pid_longitudinal_controller): add maker for stop reason Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * minor fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
Added a text marker of "steering not converged" to easily notice that the ego keeps stopped since the steering control is not converged.
![image](https://private-user-images.githubusercontent.com/20228327/311433098-3766b7c6-213f-467b-a237-3a8c53293878.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTg0NzQsIm5iZiI6MTczOTM1ODE3NCwicGF0aCI6Ii8yMDIyODMyNy8zMTE0MzMwOTgtMzc2NmI3YzYtMjEzZi00NjdiLWEyMzctM2E4YzUzMjkzODc4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMDI1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE3ZDk4ZDY3NTE2Yjc5MjhjNDY2YmY0ODhjODg3MTRhZDMxNzM5NjRkYzBlYzA3NmJkMDc1MjZiNDJiNzU2OTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.74lLEeUDxTRHUJfCMPa3kGhhQMVZBqPTSKCJCAqY12Q)
![image](https://private-user-images.githubusercontent.com/20228327/311433113-ae861074-576a-45e5-8678-8262c3164c80.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTg0NzQsIm5iZiI6MTczOTM1ODE3NCwicGF0aCI6Ii8yMDIyODMyNy8zMTE0MzMxMTMtYWU4NjEwNzQtNTc2YS00NWU1LTg2NzgtODI2MmMzMTY0YzgwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDExMDI1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiZTgxNGMxMTA0N2Q5YmZjNDYyODcxY2M2YTAzZTE0NzJmNTcxYzM4MTQyNTgxNGNjZWZhNDhlMjBhMjI5NjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.brEgR5zGj0PcSQpMsOjK-Y5SOjcljRBrkE0tBPpmHI8)
Disabled by default.
Tests performed
psim
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.