-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(start_planner): allow lane departure check override #6512
feat(start_planner): allow lane departure check override #6512
Conversation
6840e85
to
2df8ba0
Compare
4a0f3da
to
7fefab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so nice!
Thank you so much for quick work!!!!!
ebb4e3d
to
4fe39f0
Compare
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
4fe39f0
to
57c7883
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6512 +/- ##
=======================================
Coverage 14.80% 14.80%
=======================================
Files 1917 1917
Lines 131915 131878 -37
Branches 39202 39195 -7
=======================================
- Hits 19524 19523 -1
+ Misses 90609 90573 -36
Partials 21782 21782
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c36e2ef
into
autowarefoundation:main
…ndation#6512) * small refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * another refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * further refactoring Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add param to override lane_departure_check when starting outside lane Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update documentation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
* feat(start_planner): allow lane departure check override (autowarefoundation#6512) * small refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * another refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * further refactoring Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add param to override lane_departure_check when starting outside lane Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update documentation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * eliminate merge conflict problems Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * Update planning/behavior_path_start_planner_module/src/manager.cpp --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
* small refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * another refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * further refactoring Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add param to override lane_departure_check when starting outside lane Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update documentation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ndation#6512) * small refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * another refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * further refactoring Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add param to override lane_departure_check when starting outside lane Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update documentation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
…ndation#6512) * small refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * another refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * further refactoring Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add param to override lane_departure_check when starting outside lane Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update documentation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…ndation#6512) * small refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * another refactor Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * further refactoring Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add param to override lane_departure_check when starting outside lane Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update documentation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Description
Add a parameter:
allow_check_shift_path_lane_departure_override
to disable lane departure check IF the ego vehicle's original pose happens to not be fully inside a lanelet(s).Note, some refactoring is also done.
NOTE: requires launch changes-> autowarefoundation/autoware_launch#893
Tests performed
PSim tests. Example video:
cap-.2024-02-29-10-27-22.mp4
the above video shows the inclusion of the requested feature, First, I show how the start planner works if lane departure check is disabled, 2nd I enable lane departure check but also the new option to override lane departure if partly outside of lane when starting, finally I turn off the override option and the lane departure check is executed (and no path is generated) Is this the expected behavior?
Evaluator tests: TIER IV INTERNAL LINK -> No degradation related to start planner
Effects on system behavior
If enabled (default is false) this parameters disables lane departure check if the initial ego pose is already protruding outside lanelets.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.