-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start_planner): start prepare blinker when autonomous mode is available #6470
fix(start_planner): start prepare blinker when autonomous mode is available #6470
Conversation
…ilable Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6470 +/- ##
=======================================
Coverage 15.10% 15.10%
=======================================
Files 1823 1823
Lines 126312 126312
Branches 38200 38200
=======================================
Hits 19075 19075
Misses 85841 85841
Partials 21396 21396
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ilable (autowarefoundation#6470) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ilable (autowarefoundation#6470) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ilable (autowarefoundation#6470) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ilable (#6470) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…ilable (autowarefoundation#6470) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
Start the timeout count for temporal stop for blinker preparation when AW is engaged and approved.
Related links
#6412
Tests performed
if the prepare time is 3.0, even if the module is auto mode, waits for 3sec before start
RT0-30644-2024-02-21_18.03.13.mp4
By default the parameter is 0 and has no effect.
RT0-30644-2024-02-21_18.05.07.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.