Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): start prepare blinker when autonomous mode is available #6470

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 21, 2024

Description

Start the timeout count for temporal stop for blinker preparation when AW is engaged and approved.

Related links

#6412

Tests performed

if the prepare time is 3.0, even if the module is auto mode, waits for 3sec before start

RT0-30644-2024-02-21_18.03.13.mp4

By default the parameter is 0 and has no effect.

RT0-30644-2024-02-21_18.05.07.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ilable

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 21, 2024
@soblin soblin enabled auto-merge (squash) February 21, 2024 08:06
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 15.10%. Comparing base (82cc35a) to head (e0e29e4).
Report is 17 commits behind head on main.

Files Patch % Lines
..._start_planner_module/src/start_planner_module.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6470   +/-   ##
=======================================
  Coverage   15.10%   15.10%           
=======================================
  Files        1823     1823           
  Lines      126312   126312           
  Branches    38200    38200           
=======================================
  Hits        19075    19075           
  Misses      85841    85841           
  Partials    21396    21396           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.10% <ø> (+<0.01%) ⬆️ Carriedforward from 82cc35a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 2019720 into autowarefoundation:main Feb 26, 2024
30 of 32 checks passed
@soblin soblin deleted the fix/start-planner/blinker-on-start-with-engage branch February 26, 2024 13:12
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 28, 2024
…ilable (autowarefoundation#6470)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…ilable (autowarefoundation#6470)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Mar 11, 2024
…ilable (autowarefoundation#6470)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…ilable (#6470)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…ilable (autowarefoundation#6470)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants