refactor(behavior_path_planner): remove unused drivable area parameters #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
approved these changes
Feb 21, 2024
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
e73cd59 to
d30299c
Compare
|
I've rebased it to the latest main, hopefully all the checks will run this time. |
xmfcx
requested changes
Feb 29, 2024
planning/behavior_path_avoidance_module/config/avoidance.param.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6466 +/- ##
=======================================
Coverage 14.79% 14.79%
=======================================
Files 1917 1917
Lines 131987 131985 -2
Branches 39229 39228 -1
=======================================
Hits 19524 19524
+ Misses 90674 90672 -2
Partials 21789 21789
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@xmfcx thank you for fixing the CI. Can you approve the PR ? It is blocked by your "request for change". |
takayuki5168
approved these changes
Mar 1, 2024
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
…rs (#6466) * refactor(behavior_path_planner): remove unused drivable area parameters Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * Update planning/behavior_path_avoidance_module/config/avoidance.param.yaml --------- Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…rs (autowarefoundation#6466) * refactor(behavior_path_planner): remove unused drivable area parameters Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * Update planning/behavior_path_avoidance_module/config/avoidance.param.yaml --------- Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…rs (autowarefoundation#6466) * refactor(behavior_path_planner): remove unused drivable area parameters Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> * Update planning/behavior_path_avoidance_module/config/avoidance.param.yaml --------- Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused parameters
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.