fix(blockage_diag): output blockage angle range bug fix #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
This reverts commit fc43094.
yukkysaito
reviewed
Feb 19, 2024
sensing/pointcloud_preprocessor/src/blockage_diag/blockage_diag_nodelet.cpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6445 +/- ##
==========================================
- Coverage 14.99% 14.96% -0.03%
==========================================
Files 1839 1844 +5
Lines 127213 127452 +239
Branches 38132 38132
==========================================
Hits 19071 19071
- Misses 86808 87047 +239
Partials 21334 21334
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 20, 2024
…dation#6445) * fix: blockage_range_angle bug Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * Revert "chore: refactor" This reverts commit fc43094. --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
4 tasks
badai-nguyen
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 20, 2024
…dation#6445) (#1151) * fix: blockage_range_angle bug * chore: refactor * Revert "chore: refactor" This reverts commit fc43094. --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…dation#6445) * fix: blockage_range_angle bug Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * Revert "chore: refactor" This reverts commit fc43094. --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
* fix: blockage_range_angle bug Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * Revert "chore: refactor" This reverts commit fc43094. --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…dation#6445) * fix: blockage_range_angle bug Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * Revert "chore: refactor" This reverts commit fc43094. --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Link
TIER IV INTERNAL LINK
Tests performed
blockage_angle_range_degNot applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.