-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goal_planne): check objects within the area between ego edge and boudary of pull_over_lanes #6369
feat(goal_planne): check objects within the area between ego edge and boudary of pull_over_lanes #6369
Conversation
planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6369 +/- ##
==========================================
- Coverage 14.88% 14.88% -0.01%
==========================================
Files 1838 1838
Lines 126709 126765 +56
Branches 38044 38040 -4
==========================================
- Hits 18865 18863 -2
- Misses 86545 86603 +58
Partials 21299 21299
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_goal_planner_module/src/goal_planner_module.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… boudary of pull_over_lanes Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
a8b7037
to
a20071e
Compare
… boudary of pull_over_lanes (autowarefoundation#6369) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
… boudary of pull_over_lanes (autowarefoundation#6369) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
autowarefoundation/autoware_launch#867
Related links
https://tier4.atlassian.net/browse/RT1-4778
Tests performed
https://evaluation.tier4.jp/evaluation/reports/6d05a363-3ef6-536d-9f77-0cc9769c821b?project_id=prd_jt
This is an old video so at [00:09] safety check was not executed for another vehicle, but now it is fixed.
goal_planner.-2024-02-09_18.22.54.mp4
goal_planner.-2024-02-09_18.33.23.mp4
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.