Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planne): check objects within the area between ego edge and boudary of pull_over_lanes #6369

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 9, 2024

Description

autowarefoundation/autoware_launch#867

Related links

https://tier4.atlassian.net/browse/RT1-4778

Tests performed

https://evaluation.tier4.jp/evaluation/reports/6d05a363-3ef6-536d-9f77-0cc9769c821b?project_id=prd_jt

This is an old video so at [00:09] safety check was not executed for another vehicle, but now it is fixed.

goal_planner.-2024-02-09_18.22.54.mp4
goal_planner.-2024-02-09_18.33.23.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 9, 2024
@soblin soblin marked this pull request as ready for review February 9, 2024 09:25
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 11, 2024
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (99c8b32) 14.88% compared to head (a20071e) 14.88%.
Report is 5 commits behind head on main.

Files Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 50 Missing ⚠️
...ing/behavior_path_goal_planner_module/src/util.cpp 0.00% 27 Missing ⚠️
.../behavior_path_goal_planner_module/src/manager.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6369      +/-   ##
==========================================
- Coverage   14.88%   14.88%   -0.01%     
==========================================
  Files        1838     1838              
  Lines      126709   126765      +56     
  Branches    38044    38040       -4     
==========================================
- Hits        18865    18863       -2     
- Misses      86545    86603      +58     
  Partials    21299    21299              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.88% <ø> (+<0.01%) ⬆️ Carriedforward from 99c8b32

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

… boudary of pull_over_lanes

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/goal_planner/check-between-ego-pull-over-lanes branch from a8b7037 to a20071e Compare February 13, 2024 04:10
@soblin soblin merged commit bd30a66 into autowarefoundation:main Feb 13, 2024
19 of 24 checks passed
@soblin soblin deleted the feat/goal_planner/check-between-ego-pull-over-lanes branch February 13, 2024 04:37
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
… boudary of pull_over_lanes (autowarefoundation#6369)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… boudary of pull_over_lanes (autowarefoundation#6369)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants