Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map based prediction, crosswalk)!: transplantation of pedestrians' behavior prediction against green signal #6338

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Feb 6, 2024

Description

Re-implementation of pedestrians' behavior prediction against green signal

image

Screencast.from.02-07-2024.05.33.45.PM.webm

Related links

launch PR: autowarefoundation/autoware_launch#860

Tests performed

psim and tier4 internal tests
https://evaluation.tier4.jp/evaluation/reports/3b89397e-be2d-578a-a5d5-e5eda5c762a1?project_id=prd_jt

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 6, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 changed the title Feat/map based prediction/ped estimation against green feat(map based prediction, crosswalk)!: transplantation of pedstrians' prediction against green signal Feb 7, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title feat(map based prediction, crosswalk)!: transplantation of pedstrians' prediction against green signal feat(map based prediction, crosswalk)!: transplantation of pedstrians' behaivior prediction against green signal Feb 7, 2024
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 7, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title feat(map based prediction, crosswalk)!: transplantation of pedstrians' behaivior prediction against green signal feat(map based prediction, crosswalk)!: transplantation of pedestrians' behavior prediction against green signal Feb 7, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review February 7, 2024 08:50
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (bd4b5ca) 14.36% compared to head (d82c6d5) 14.36%.
Report is 37 commits behind head on main.

Files Patch % Lines
...based_prediction/src/map_based_prediction_node.cpp 0.00% 44 Missing ⚠️
...behavior_velocity_crosswalk_module/src/manager.cpp 0.00% 0 Missing and 4 partials ⚠️
..._velocity_crosswalk_module/src/scene_crosswalk.hpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6338      +/-   ##
==========================================
- Coverage   14.36%   14.36%   -0.01%     
==========================================
  Files        1907     1907              
  Lines      130136   130167      +31     
  Branches    37640    37636       -4     
==========================================
  Hits        18697    18697              
- Misses      90430    90463      +33     
+ Partials    21009    21007       -2     
Flag Coverage Δ *Carryforward flag
differential 7.61% <0.00%> (?)
total 14.36% <ø> (+<0.01%) ⬆️ Carriedforward from bd4b5ca

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit 1c54d43 into autowarefoundation:main Feb 9, 2024
36 of 43 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/map_based_prediction/ped_estimation_against_green branch February 9, 2024 04:31
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Feb 19, 2024
…s' behavior prediction against green signal (autowarefoundation#6338)

* pedestrians' intention estimation feature against the green signal
* delete the reimplimented feature
* sync params
* update docs
---------
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…s' behavior prediction against green signal (autowarefoundation#6338)

* pedestrians' intention estimation feature against the green signal
* delete the reimplimented feature
* sync params
* update docs
---------
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…s' behavior prediction against green signal (autowarefoundation#6338)

* pedestrians' intention estimation feature against the green signal
* delete the reimplimented feature
* sync params
* update docs
---------
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants