Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): ghost debug markers due to duplicated marker id #6330

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 6, 2024

Description

Threre are ghost avoidance debug marker because of marker id duplication. (green cylinder)

Screenshot from 2024-02-06 13-43-16

Tests performed

Psim + replayer

simplescreenrecorder-2024-02-06_13.36.14.mp4

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 6, 2024
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 6, 2024
@satoshi-ota satoshi-ota changed the title fix(avoidance): fix duplicated marker id fix(avoidance): ghost debug markers due to duplicated marker id Feb 6, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review February 6, 2024 04:45
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9601a3e) 14.89% compared to head (ca31cd3) 14.89%.
Report is 7 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/debug.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6330   +/-   ##
=======================================
  Coverage   14.89%   14.89%           
=======================================
  Files        1817     1817           
  Lines      125471   125471           
  Branches    37711    37711           
=======================================
  Hits        18695    18695           
  Misses      85752    85752           
  Partials    21024    21024           
Flag Coverage Δ *Carryforward flag
differential 13.05% <0.00%> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from 9601a3e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit c859790 into autowarefoundation:main Feb 7, 2024
44 of 46 checks passed
@satoshi-ota satoshi-ota deleted the fix/duplicate-marker-id branch February 7, 2024 00:09
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 7, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 8, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…warefoundation#6330)

fix(avoidance): fix duplicated marker id

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants