Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): fix stopline midpoint calculation #6315

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 5, 2024

Description

fixed the wrong midpoint calculation from

x + y /  2.0

to

(x + y) / 2.0

Related links

https://tier4.atlassian.net/browse/RT1-4773

Tests performed

before

at [00:15], unnecessary stop happens due to miscalculation

_decel4.0-2024-02-05_16.36.14.mp4

after

_decel4.0-2024-02-05_16.39.16.mp4

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 5, 2024
@takayuki5168
Copy link
Contributor

OMG!

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 5, 2024
@soblin soblin enabled auto-merge (squash) February 5, 2024 10:12
@soblin soblin merged commit c0d7904 into autowarefoundation:main Feb 5, 2024
25 of 26 checks passed
@soblin soblin deleted the fix/intersection/ignore-red-signal branch February 5, 2024 14:21
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Feb 6, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Feb 6, 2024
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants