-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection_occlusion)!: react RTC disapproval and stop even if occlusion detection is OFF #6279
Merged
soblin
merged 1 commit into
autowarefoundation:main
from
tier4:feat/intersection_occlusion/react-disapproval-when-detection-is-disabled
Feb 1, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…occlusion detection is OFF Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
takayuki5168
approved these changes
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6279 +/- ##
=======================================
Coverage 14.93% 14.93%
=======================================
Files 1816 1816
Lines 125113 125112 -1
Branches 37615 37614 -1
=======================================
Hits 18691 18691
+ Misses 85410 85409 -1
Partials 21012 21012
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Feb 1, 2024
… occlusion detection is OFF (autowarefoundation#6279) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Feb 1, 2024
… occlusion detection is OFF (autowarefoundation#6279) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
… occlusion detection is OFF (autowarefoundation#6279) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
… occlusion detection is OFF (autowarefoundation#6279) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
… occlusion detection is OFF (autowarefoundation#6279) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Nov 9, 2024
… occlusion detection is OFF (autowarefoundation#6279) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently INTERSECTION_OCCLUSION does not respond to RTC disapproval if the
occlusion.enable
is OFF, based on the assumption that the user will not have the need to stop at intersection_occlusion stopline if he/she disabledocclusion.enable
. With this change, INTERSECTION_OCCLUSION responds RTC disapproval even ifocclusion.enable
is OFF.Related links
Tests performed
PR6201-2024-02-01_15.45.06.mp4
Notes for reviewers
Interface changes
INTERSECTION_OCCLUSION stops if it is manual even if
occlusion.enable
is OFF and the user intentionally disabled occlusion detection.Effects on system behavior
INTERSECTION_OCCLUSION stops if it is manual even if
occlusion.enable
is OFF and the user intentionally disabled occlusion detection.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.