Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection_occlusion)!: react RTC disapproval and stop even if occlusion detection is OFF #6279

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 1, 2024

Description

currently INTERSECTION_OCCLUSION does not respond to RTC disapproval if the occlusion.enable is OFF, based on the assumption that the user will not have the need to stop at intersection_occlusion stopline if he/she disabled occlusion.enable. With this change, INTERSECTION_OCCLUSION responds RTC disapproval even if occlusion.enable is OFF.

Related links

Tests performed

PR6201-2024-02-01_15.45.06.mp4

Notes for reviewers

Interface changes

INTERSECTION_OCCLUSION stops if it is manual even if occlusion.enable is OFF and the user intentionally disabled occlusion detection.

Effects on system behavior

INTERSECTION_OCCLUSION stops if it is manual even if occlusion.enable is OFF and the user intentionally disabled occlusion detection.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…occlusion detection is OFF

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 1, 2024
@soblin soblin changed the title feat!(intersection_occlusion): react RTC disapproval and stop even if occlusion detection is OFF feat(intersection_occlusion)!: react RTC disapproval and stop even if occlusion detection is OFF Feb 1, 2024
@soblin soblin marked this pull request as ready for review February 1, 2024 07:01
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 1, 2024
@soblin soblin enabled auto-merge (squash) February 1, 2024 07:07
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (9313a4c) 14.93% compared to head (e604de5) 14.93%.
Report is 17 commits behind head on main.

Files Patch % Lines
...ity_intersection_module/src/scene_intersection.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6279   +/-   ##
=======================================
  Coverage   14.93%   14.93%           
=======================================
  Files        1816     1816           
  Lines      125113   125112    -1     
  Branches    37615    37614    -1     
=======================================
  Hits        18691    18691           
+ Misses      85410    85409    -1     
  Partials    21012    21012           
Flag Coverage Δ *Carryforward flag
differential 4.69% <0.00%> (?)
total 14.94% <ø> (+<0.01%) ⬆️ Carriedforward from 9313a4c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit ee25365 into autowarefoundation:main Feb 1, 2024
31 of 34 checks passed
@soblin soblin deleted the feat/intersection_occlusion/react-disapproval-when-detection-is-disabled branch February 1, 2024 08:23
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Feb 1, 2024
… occlusion detection is OFF (autowarefoundation#6279)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Feb 1, 2024
… occlusion detection is OFF (autowarefoundation#6279)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… occlusion detection is OFF (autowarefoundation#6279)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
… occlusion detection is OFF (autowarefoundation#6279)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
… occlusion detection is OFF (autowarefoundation#6279)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 9, 2024
… occlusion detection is OFF (autowarefoundation#6279)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants