Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(twist2accel): rework parameters #6266

Conversation

SakodaShintaro
Copy link
Contributor

This PR must be merged with autowarefoundation/autoware_launch#842

Description

rework parameters about twist2accel

Tests performed

It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.

find -wholename '*/schema/*.schema.json' -printf '%p: ' -execdir bash -c 'check-jsonschema --schemafile "$1" ../config/"${1:2:-12}"*.param.yaml' bash '{}' +

Effects on system behavior

There are no effects on system behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 1, 2024
@SakodaShintaro SakodaShintaro self-assigned this Feb 1, 2024
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Feb 1, 2024
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Feb 1, 2024
@KYabuuchi
Copy link
Contributor

Please remove default values in twist2accel.cpp 🙏

image

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
@SakodaShintaro
Copy link
Contributor Author

@KYabuuchi
I forgot it. Fixed in 3dadcc9

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 🙆

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (47eeb70) 14.38% compared to head (77a3c76) 14.38%.
Report is 3 commits behind head on main.

Files Patch % Lines
localization/twist2accel/src/twist2accel.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6266   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files        1906     1906           
  Lines      129909   129909           
  Branches    37616    37616           
=======================================
+ Hits        18689    18691    +2     
  Misses      90206    90206           
+ Partials    21014    21012    -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.38% <ø> (+<0.01%) ⬆️ Carriedforward from 0a77e4e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit b85f13a into autowarefoundation:main Feb 1, 2024
21 of 24 checks passed
@SakodaShintaro SakodaShintaro deleted the chore/add_json_schema_to_twist2accel branch February 1, 2024 08:03
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Feb 1, 2024
* Added twist2accel.param.yaml

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Added twist2accel.schema.json

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Fixed README.md and description

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Removed default parameters

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Feb 1, 2024
* Added twist2accel.param.yaml

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Added twist2accel.schema.json

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Fixed README.md and description

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Removed default parameters

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* Added twist2accel.param.yaml

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Added twist2accel.schema.json

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* Fixed README.md and description

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

* style(pre-commit): autofix

* Removed default parameters

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants