-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(twist2accel): rework parameters #6266
chore(twist2accel): rework parameters #6266
Conversation
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp>
@KYabuuchi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 🙆
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6266 +/- ##
=======================================
Coverage 14.38% 14.38%
=======================================
Files 1906 1906
Lines 129909 129909
Branches 37616 37616
=======================================
+ Hits 18689 18691 +2
Misses 90206 90206
+ Partials 21014 21012 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b85f13a
into
autowarefoundation:main
* Added twist2accel.param.yaml Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Added twist2accel.schema.json Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Fixed README.md and description Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Removed default parameters Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Added twist2accel.param.yaml Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Added twist2accel.schema.json Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Fixed README.md and description Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Removed default parameters Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Added twist2accel.param.yaml Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Added twist2accel.schema.json Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * Fixed README.md and description Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> * style(pre-commit): autofix * Removed default parameters Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro SAKODA <shintaro.sakoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This PR must be merged with autowarefoundation/autoware_launch#842
Description
rework parameters about twist2accel
Tests performed
It has been confirmed that the
logging_simulator
runs with the same accuracy as before on AWSIM data with GT.Effects on system behavior
There are no effects on system behavior.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.