feat(lane_change): wait approval with abort state #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6234 +/- ##
==========================================
- Coverage 14.40% 14.39% -0.01%
==========================================
Files 1906 1906
Lines 129839 129849 +10
Branches 37571 37582 +11
==========================================
Hits 18697 18697
- Misses 90147 90157 +10
Partials 20995 20995
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 9, 2024
…#6234) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
7 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…#6234) Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, lane change module does not generate lane change path during abort state.
In this change, it will generate lane change path and wait approval during abort state.
Related links
Tests performed
TIER IV INTERNAL LINK
Screencast.from.2024.01.30.17.24.05.webm
Notes for reviewers
Interface changes
Not applicable.
Effects on system behavior
Lane change module outputs lane change candidate during abort state.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.