-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(planning/control/vehicle): declare ROS params in yaml files #6217
Merged
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:planning-control-vehicle/clean-up-launch-file
Feb 7, 2024
Merged
chore(planning/control/vehicle): declare ROS params in yaml files #6217
yuki-takagi-66
merged 4 commits into
autowarefoundation:main
from
tier4:planning-control-vehicle/clean-up-launch-file
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rej55
approved these changes
Jan 30, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
15d5d99
to
721bfce
Compare
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
7e5a7fc
to
4a639c2
Compare
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6217 +/- ##
=======================================
Coverage 14.38% 14.39%
=======================================
Files 1906 1906
Lines 129910 129912 +2
Branches 37616 37618 +2
=======================================
+ Hits 18691 18701 +10
+ Misses 90207 90197 -10
- Partials 21012 21014 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TakaHoribe
approved these changes
Feb 7, 2024
satoshi-ota
approved these changes
Feb 7, 2024
7e53f30
into
autowarefoundation:main
22 of 25 checks passed
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…towarefoundation#6217) * clean up launch file * add yaml Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
xmfcx
reviewed
Feb 21, 2024
4 tasks
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…towarefoundation#6217) * clean up launch file * add yaml Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…towarefoundation#6217) * clean up launch file * add yaml Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:vehicle
Vehicle-specific implementations, drivers, packages. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to ready for JSON scheme, change ROS params to declare in yaml files.
launch: autowarefoundation/autoware_launch#833
the work for raw_vehicle_cmd_converter is still remain.
Tests performed
Not yet
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.