Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(planning/control/vehicle): declare ROS params in yaml files #6217

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jan 29, 2024

Description

In order to ready for JSON scheme, change ROS params to declare in yaml files.
launch: autowarefoundation/autoware_launch#833

the work for raw_vehicle_cmd_converter is still remain.

Tests performed

Not yet

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) labels Jan 29, 2024
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 29, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review January 30, 2024 05:30
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 force-pushed the planning-control-vehicle/clean-up-launch-file branch from 15d5d99 to 721bfce Compare February 1, 2024 06:43
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 force-pushed the planning-control-vehicle/clean-up-launch-file branch from 7e5a7fc to 4a639c2 Compare February 1, 2024 07:10
@yuki-takagi-66 yuki-takagi-66 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 1, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2e4b25a) 14.38% compared to head (e447055) 14.39%.
Report is 15 commits behind head on main.

Files Patch % Lines
.../test/src/test_filter_in_vehicle_cmd_gate_node.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6217   +/-   ##
=======================================
  Coverage   14.38%   14.39%           
=======================================
  Files        1906     1906           
  Lines      129910   129912    +2     
  Branches    37616    37618    +2     
=======================================
+ Hits        18691    18701   +10     
+ Misses      90207    90197   -10     
- Partials    21012    21014    +2     
Flag Coverage Δ *Carryforward flag
differential 24.51% <0.00%> (?)
total 14.38% <ø> (ø) Carriedforward from 2e4b25a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit 7e53f30 into autowarefoundation:main Feb 7, 2024
22 of 25 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the planning-control-vehicle/clean-up-launch-file branch February 7, 2024 05:41
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…towarefoundation#6217)

* clean up launch file
* add yaml

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…towarefoundation#6217)

* clean up launch file
* add yaml

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…towarefoundation#6217)

* clean up launch file
* add yaml

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants