Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): display stop pose infomation #6119

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 19, 2024

Description

store info strings with stop_pose_ and display them as debug marker
image

Tests performed

evaluator_description: feat/stop_pose_info
2024/01/19 https://evaluation.tier4.jp/evaluation/reports/8b9874ba-f0fc-5b31-b784-77595d0eaad9/?project_id=prd_jt

https://evaluation.tier4.jp/evaluation/reports/b213ad21-1371-5559-bdbf-e86f8de56a13?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 marked this pull request as ready for review January 19, 2024 07:17
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 19, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

change message

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

update

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/stop_pose_info branch from 2a94105 to b19c82e Compare January 19, 2024 07:19
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (c833bea) 14.61% compared to head (b19c82e) 14.61%.
Report is 8 commits behind head on main.

Files Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 43 Missing ⚠️
...r_path_goal_planner_module/goal_planner_module.hpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6119      +/-   ##
==========================================
- Coverage   14.61%   14.61%   -0.01%     
==========================================
  Files        1859     1859              
  Lines      127242   127278      +36     
  Branches    37275    37275              
==========================================
  Hits        18598    18598              
- Misses      87727    87763      +36     
  Partials    20917    20917              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.61% <ø> (+<0.01%) ⬆️ Carriedforward from c833bea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 1a23d01 into main Jan 21, 2024
32 of 36 checks passed
@kosuke55 kosuke55 deleted the feat/stop_pose_info branch January 21, 2024 05:03
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
…6119)

change message



update

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
…6119)

change message



update

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 28, 2024
…6119)

change message



update

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…6119)

change message



update

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants