Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): add a guard of LPF for reference path changed by avoidance/LC #6112

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jan 18, 2024

Description

  • check if the lowpass filter to the lateral offset to avoid should be enabled or not depending on whether the reference path changes or not.
  • Tuned the parameter when to start avoiding the front object whose direction is the same as the ego.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…d by avoidance/LC

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 18, 2024
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 18, 2024
@takayuki5168 takayuki5168 marked this pull request as ready for review January 18, 2024 13:21
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (e3d4e75) 14.62% compared to head (908465b) 14.62%.
Report is 14 commits behind head on main.

Files Patch % Lines
...havior_path_dynamic_avoidance_module/src/scene.cpp 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6112      +/-   ##
==========================================
- Coverage   14.62%   14.62%   -0.01%     
==========================================
  Files        1860     1860              
  Lines      127169   127179      +10     
  Branches    37228    37232       +4     
==========================================
  Hits        18597    18597              
- Misses      87658    87668      +10     
  Partials    20914    20914              
Flag Coverage Δ *Carryforward flag
differential 6.92% <0.00%> (?)
total 14.62% <ø> (+<0.01%) ⬆️ Carriedforward from e3d4e75

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 19009f7 into autowarefoundation:main Jan 21, 2024
35 of 39 checks passed
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-dynamic-ref-path-main branch January 21, 2024 17:07
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
…d by avoidance/LC (autowarefoundation#6112)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
…d by avoidance/LC (autowarefoundation#6112)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
…d by avoidance/LC (autowarefoundation#6112)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
…d by avoidance/LC (autowarefoundation#6112)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…d by avoidance/LC (autowarefoundation#6112)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants