Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: prefix packages with autoware_ #6067

Closed
wants to merge 68 commits into from
Closed

build: prefix packages with autoware_ #6067

wants to merge 68 commits into from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jan 12, 2024

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jan 12, 2024
esteve and others added 2 commits January 15, 2024 12:20
@esteve
build: prefix packages with autoware_
eef7659 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci @esteve
style(pre-commit): autofix
75cdcfe
esteve added 12 commits January 15, 2024 13:35
@esteve
build(osqp_interface): use ${PROJECT_NAME} for autoware_osqp_interfac…
93a7305 
…e targets

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(polar_grid): use ${PROJECT_NAME} for autoware_polar_grid targets
c80ef03 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(qp_interface): use ${PROJECT_NAME} for autoware_qp_interface ta…
b9c444f 
…rgets

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(tvm_utility): rename extras file
d3132c9 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(tvm_utility): use tvm_utility for include directory
f485c51 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(global_parameter_loader): do not prefix with autoware_
77a3320 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(tier4_autoware_api_launch): do not prefix with autoware_
890e2a8 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build: do not prefix launch packages with autoware_
46b00ae 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(kinematic_evaluator): rename node source file to match project …
78659a5 
…name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix(kinematic_evaluator): fix node name in launch files
f3cd5d0 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(localization_evaluator): rename source file and fix launch file…
01270ec 
…s to match project name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(localization_evaluator): rename source file and fix launch file…
967f357 
…s to match project name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@xmfcx
Copy link
Contributor

xmfcx commented Jan 18, 2024 •
edited
Loading

Related discussion: Prefix packages with autoware_ (4097)

@esteve
build(planning_evaluator): rename source file and fix launch files to…
08f2b99 
… match project name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
esteve added 12 commits February 2, 2024 13:52
@esteve
build(detection_by_tracker): do not prefix with autoware_
66d7b7c 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(ground_segmentation): do not prefix with autoware_
efccb47 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(image_projection_based_fusion): do not prefix with autoware_
a716979 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(lidar_apollo_instance_segmentation): do not prefix with autoware_
f81663f 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(multi_object_tracker): do not prefix with autoware_
1348cfd 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(gnss_poser): do not prefix with autoware_
5903b72 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(ad_api_adaptors): do not prefix with autoware_
67446bd 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(lidar_apollo_instance_segmentation): fix references for tier4_a…
46726f9 
…utoware_utils

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(planning_debug_tools): fix message namespace
898a144 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(rtc_replayer): fix source file name
ff84beb 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(path_smoother): rename node source file to match project name
3e4f82f 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(path_smoother): add include directory to CMake target
ed2156c 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
esteve added 14 commits February 6, 2024 14:28
@esteve
build(scenario_selector): rename source file to match project name
7507b2d 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(control_performance_analysis): fix include paths and namespaces…
68143ae 
… for messages

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(control_validator): fix include paths and namespaces for messages
4acb2fc 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(freespace_planner): rename source file to match project name
071e0dd 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(freespace_planner): fix target dependency
32c43cb 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(behavior_velocity_planner): fix include paths and namespaces fo…
ba85c97 
…r messages

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(obstacle_avoidance_planner): rename source file to match projec…
a02020c 
…t name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(obstacle_stop_planner): rename source file to match project name
224f53f 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(obstacle_velocity_limiter): rename source file to match project…
8f14b08 
… name

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(operation_mode_transition_manager): fix include paths and names…
bb7bfad 
…paces for messages

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(planning_validator): rename source file to match project name
baf4c0c 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(static_centerline_optimizer): fix include paths and namespaces …
ddabe22 
…for messages

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(trajectory_follower_node): fix target dependency
21b0f30 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
build(vehicle_cmd_gate): fix include paths and namespaces for messages
1a71dfb 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
Copy link
Contributor Author

esteve commented Mar 27, 2024

Closing in favor of submitting per-package PRs

@esteve esteve closed this Mar 27, 2024
@esteve esteve deleted the rename-packages branch March 27, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r will be requested when the pull request is marked ready for review mitsudome-r is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi will be requested when the pull request is marked ready for review isamu-takagi is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 will be requested when the pull request is marked ready for review anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi will be requested when the pull request is marked ready for review KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san will be requested when the pull request is marked ready for review Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto will be requested when the pull request is marked ready for review RyuYamamoto is a code owner

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro SakodaShintaro will be requested when the pull request is marked ready for review SakodaShintaro is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 will be requested when the pull request is marked ready for review TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo will be requested when the pull request is marked ready for review YamatoAndo is a code owner

@ito-san ito-san Awaiting requested review from ito-san ito-san will be requested when the pull request is marked ready for review ito-san is a code owner

@TetsuKawa TetsuKawa Awaiting requested review from TetsuKawa TetsuKawa will be requested when the pull request is marked ready for review TetsuKawa is a code owner

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima will be requested when the pull request is marked ready for review KeisukeShima is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 will be requested when the pull request is marked ready for review taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe will be requested when the pull request is marked ready for review TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 will be requested when the pull request is marked ready for review takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 will be requested when the pull request is marked ready for review tkimura4 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 will be requested when the pull request is marked ready for review rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 will be requested when the pull request is marked ready for review kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara will be requested when the pull request is marked ready for review kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri will be requested when the pull request is marked ready for review mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin will be requested when the pull request is marked ready for review soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota will be requested when the pull request is marked ready for review satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk will be requested when the pull request is marked ready for review shmpwk is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo will be requested when the pull request is marked ready for review TomohitoAndo is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 will be requested when the pull request is marked ready for review zulfaqar-azmi-t4 is a code owner

@miursh miursh Awaiting requested review from miursh miursh will be requested when the pull request is marked ready for review miursh is a code owner

@technolojin technolojin Awaiting requested review from technolojin technolojin will be requested when the pull request is marked ready for review technolojin is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi will be requested when the pull request is marked ready for review YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito will be requested when the pull request is marked ready for review yukkysaito is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteve @xmfcx