-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(landmark_manager): add get_landmarrks func #6063
feat(landmark_manager): add get_landmarrks func #6063
Conversation
Signed-off-by: yamato-ando <Yamato ANDO>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Me
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6063 +/- ##
==========================================
- Coverage 14.65% 14.64% -0.01%
==========================================
Files 1857 1858 +1
Lines 126512 126520 +8
Branches 37059 37063 +4
==========================================
Hits 18535 18535
- Misses 87154 87162 +8
Partials 20823 20823
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
A function has been added to return an array of landmarks in the
landmark_manager
.This function is intended to be used in the
lidar_marker_localizer
for searching the nearest landmark and so on.Tests performed
LSim works.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.