fix(intersection): fix bugs

[soblin]

Description

occlusion.max_clearance_distance was not initialized so occlusion detection was not working well. Also is_amber_or_red variable was declared as double unintentionally.

Related links

Tests performed

occlusion feature works as before

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (28c871a) 14.64% compared to head (f187053) 14.64%.
Report is 8 commits behind head on main.

Files	Patch %	Lines
...avior_velocity_intersection_module/src/manager.cpp	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6050      +/-   ##
==========================================
- Coverage   14.64%   14.64%   -0.01%     
==========================================
  Files        1857     1857              
  Lines      126480   126481       +1     
  Branches    37048    37050       +2     
==========================================
  Hits        18526    18526              
+ Misses      87138    87137       -1     
- Partials    20816    20818       +2     

Flag	Coverage Δ		*Carryforward flag
differential	5.20% <0.00%> (?)
total	14.64% <ø> (+<0.01%)	⬆️	Carriedforward from 28c871a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.