Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(start_planner): update explanation about start pose candidate's priority #6003

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

add explanation about start pose candidate priority

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 1, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title add explanation about start pose candidate priority docs(start_planner): Update explanation about start pose candidate's priority Jan 1, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does 3 in (3. geometric_pull_out) mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the comment!
3 is idx of the start pose candidate and updated image with 552a642

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!!

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@kyoichi-sugahara kyoichi-sugahara changed the title docs(start_planner): Update explanation about start pose candidate's priority docs(start_planner): update explanation about start pose candidate's priority Jan 10, 2024
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 10, 2024
@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) January 10, 2024 00:13
@kyoichi-sugahara kyoichi-sugahara merged commit bbde223 into autowarefoundation:main Jan 10, 2024
28 of 29 checks passed
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Jan 11, 2024
…priority (autowarefoundation#6003)

* add explanation about start pose candidate priority

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
@kyoichi-sugahara kyoichi-sugahara deleted the feat/start_planner_search_start_pose_priority branch February 8, 2024 02:34
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…priority (autowarefoundation#6003)

* add explanation about start pose candidate priority

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…priority (autowarefoundation#6003)

* add explanation about start pose candidate priority

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…priority (autowarefoundation#6003)

* add explanation about start pose candidate priority

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…priority (autowarefoundation#6003)

* add explanation about start pose candidate priority

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants