Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(map_height_fitter): set log level of debug printing to DEBUG #5997

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 28, 2023

Description

The map_height_fitter package shows the following debug printing every time the ego pose is set, which is unnecessary for daily use.

[initial_pose_adaptor-37] [INFO 1703780545.900383599] [default_ad_api.helpers.initial_pose_adaptor]: original point: 89389.414 43158.734 0.000 (fit():171)
[initial_pose_adaptor-37] [INFO 1703780545.901397153] [default_ad_api.helpers.initial_pose_adaptor]: Send request to map_loader (get_partial_point_cloud_map():104)
[initial_pose_adaptor-37] [INFO 1703780545.902191874] [default_ad_api.helpers.initial_pose_adaptor]: Loaded partial pcd map from map_loader (grid size: 0) (get_partial_point_cloud_map():116)
[initial_pose_adaptor-37] [INFO 1703780545.902478060] [default_ad_api.helpers.initial_pose_adaptor]: modified point: 89389.414 43158.734 0.000 (fit():196)

This PR sets its log level from INFO to DEBUG.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Dec 28, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review December 28, 2023 17:08
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7676228) 15.24% compared to head (c18c76a) 15.24%.
Report is 13 commits behind head on main.

Files Patch % Lines
map/map_height_fitter/src/map_height_fitter.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5997   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files        1750     1750           
  Lines      120658   120658           
  Branches    36738    36738           
=======================================
  Hits        18392    18392           
  Misses      81638    81638           
  Partials    20628    20628           
Flag Coverage Δ *Carryforward flag
differential 3.58% <0.00%> (?)
total 15.24% <ø> (+<0.01%) ⬆️ Carriedforward from 7676228

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 67080aa into autowarefoundation:main Jan 5, 2024
36 of 38 checks passed
@takayuki5168 takayuki5168 deleted the chore/map-height-debug-level branch January 5, 2024 07:36
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants