Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geography_utils): add mgrs code in projector #5990

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 28, 2023

Description

Without this PR, when handling the MGRS projector created by geography_utils::get_lanelet2_projector, the following error occurred.
https://github.com/autowarefoundation/autoware_common/blob/6bbda6513206ea968f76f310a4bf2847bff3a583/tmp/lanelet2_extension/lib/mgrs_projector.cpp#L82-L83

Tests performed

Run static_centerline_optimizer's script

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 28, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review December 28, 2023 06:21
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 28, 2023
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7676228) 15.24% compared to head (9202230) 15.24%.
Report is 9 commits behind head on main.

Files Patch % Lines
common/geography_utils/src/lanelet2_projector.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5990   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files        1750     1750           
  Lines      120658   120680   +22     
  Branches    36738    36754   +16     
=======================================
+ Hits        18392    18397    +5     
  Misses      81638    81638           
- Partials    20628    20645   +17     
Flag Coverage Δ *Carryforward flag
differential 23.00% <0.00%> (?)
total 15.24% <ø> (ø) Carriedforward from 7676228

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda merged commit a4c9207 into autowarefoundation:main Jan 15, 2024
34 of 36 checks passed
@kminoda kminoda deleted the fix/set-mgrs-code branch January 15, 2024 00:40
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…#5990)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…#5990)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…#5990)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…#5990)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants