-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geography_utils): add mgrs code in projector #5990
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5990 +/- ##
=======================================
Coverage 15.24% 15.24%
=======================================
Files 1750 1750
Lines 120658 120680 +22
Branches 36738 36754 +16
=======================================
+ Hits 18392 18397 +5
Misses 81638 81638
- Partials 20628 20645 +17
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…#5990) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…#5990) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…#5990) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…#5990) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
Without this PR, when handling the MGRS projector created by
geography_utils::get_lanelet2_projector
, the following error occurred.https://github.com/autowarefoundation/autoware_common/blob/6bbda6513206ea968f76f310a4bf2847bff3a583/tmp/lanelet2_extension/lib/mgrs_projector.cpp#L82-L83
Tests performed
Run static_centerline_optimizer's script
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.