-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crosswalk): add interset makers #5967
feat(crosswalk): add interset makers #5967
Conversation
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks 👍
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5967 +/- ##
=======================================
Coverage 15.29% 15.29%
=======================================
Files 1750 1750
Lines 120566 120610 +44
Branches 36783 36815 +32
=======================================
+ Hits 18435 18447 +12
- Misses 81465 81473 +8
- Partials 20666 20690 +24
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2eb8dfb
into
autowarefoundation:main
add interest makers Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
add interest makers Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
add interest makers Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
add interest makers Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Description
The module side modification regarding to #5875
Screencast from 12-26-2023 05:11:20 PM.webm
Tests performed
Psim test was performed.
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.