Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): add interset makers #5967

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Dec 26, 2023

Description

The module side modification regarding to #5875

Uploading image.png…
Screencast from 12-26-2023 05:11:20 PM.webm

Screenshot from 2023-12-26 17-36-08

Tests performed

Psim test was performed.

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 26, 2023
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2023
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (64c6dba) 15.29% compared to head (55bf72d) 15.29%.
Report is 12 commits behind head on main.

Files Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5967   +/-   ##
=======================================
  Coverage   15.29%   15.29%           
=======================================
  Files        1750     1750           
  Lines      120566   120610   +44     
  Branches    36783    36815   +32     
=======================================
+ Hits        18435    18447   +12     
- Misses      81465    81473    +8     
- Partials    20666    20690   +24     
Flag Coverage Δ *Carryforward flag
differential 12.11% <0.00%> (?)
total 15.29% <ø> (+<0.01%) ⬆️ Carriedforward from 64c6dba

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit 2eb8dfb into autowarefoundation:main Dec 27, 2023
39 of 42 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/crosswalk/add-interest-markers branch December 27, 2023 02:18
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
add interest makers

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
add interest makers

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
add interest makers

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
add interest makers

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants