Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): change the logic of longitudinal distance to… #5947

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 23, 2023

Description

  • implemented time_while_collision instead of time_to_collision that includes time_to_start/end_collision.
    • If there is no collision, the time will be infinite.
  • changed the logic of longitudinal distance to avoid
    • When the object is in the same direction as the ego, the start position to avoid is calculated keeping the distance assuming that the object may decelerate.
    • When the object is in the opposite direction of the ego, the start position to avoid is calculated by TTC.
  • Fixed the issue of the unstable ends' position for avoidance by calcValidLengthToAvoid.

Tests performed

psim

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 23, 2023
… avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/dynamic-avoidance-lon-avoid-length branch from f0baf65 to 8dff63d Compare December 23, 2023 07:37
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 109 lines in your changes are missing coverage. Please review.

Comparison is base (a4ef3a0) 15.29% compared to head (c50519d) 15.20%.
Report is 31 commits behind head on main.

Files Patch % Lines
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% 105 Missing ⚠️
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5947      +/-   ##
==========================================
- Coverage   15.29%   15.20%   -0.10%     
==========================================
  Files        1747     1748       +1     
  Lines      120251   122946    +2695     
  Branches    36656    38096    +1440     
==========================================
+ Hits        18390    18691     +301     
- Misses      81234    83167    +1933     
- Partials    20627    21088     +461     
Flag Coverage Δ *Carryforward flag
differential 9.35% <0.00%> (?)
total 15.29% <ø> (+<0.01%) ⬆️ Carriedforward from 8dff63d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 9ccb981 into autowarefoundation:main Dec 25, 2023
19 of 23 checks passed
@takayuki5168 takayuki5168 deleted the fix/dynamic-avoidance-lon-avoid-length branch December 25, 2023 05:43
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
autowarefoundation#5947)

* feat(dynamic_avoidance): change the logic of longitudinal distance to avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix typo

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
autowarefoundation#5947)

* feat(dynamic_avoidance): change the logic of longitudinal distance to avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix typo

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
autowarefoundation#5947)

* feat(dynamic_avoidance): change the logic of longitudinal distance to avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix typo

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
autowarefoundation#5947)

* feat(dynamic_avoidance): change the logic of longitudinal distance to avoid

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix typo

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants