Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(behavior_velocity_planner): use DEBUG for launching modules #5897

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore(behavior_velocity_planner): use DEBUG for launching modules #5897

merged 1 commit into from
Dec 18, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 18, 2023 •
edited
Loading

Description

When launching behavior_velocity_planner's modules, the following message to register the new modules is shown, which is for developers but makes the terminal messy.

[component_container_mt-29] [INFO 1702873200.701397039] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = crosswalk, id = 1595 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.703595298] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = crosswalk, id = 1598 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.707912157] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = crosswalk, id = 1596 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.724486464] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = traffic_light, id = 1114 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.724625789] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = traffic_light, id = 1128 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.729213898] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = intersection, id = 1128 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.732657760] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = intersection, id = 1114 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.748576996] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = blind_spot, id = 1128 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.768965304] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = run_out, id = 0 (registerModule():177)
[component_container_mt-29] [INFO 1702873200.773928139] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner]: register task: module = out_of_lane, id = 0 (registerModule():177)

This PR makes it to use DEBUG instead of INFO

Tests performed

psim

Effects on system behavior

nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168
chore(behavior_velocity_planner): use DEBUG for launching modules
0c90e1f 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review December 18, 2023 04:44
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 18, 2023
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 18, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (90d5b94) 15.30% compared to head (0c90e1f) 15.30%.
Report is 6 commits behind head on main.

Files Patch % Lines
...city_planner_common/src/scene_module_interface.cpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5897   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files        1747     1747           
  Lines      120119   120119           
  Branches    36570    36570           
=======================================
  Hits        18380    18380           
  Misses      81124    81124           
  Partials    20615    20615
Flag Coverage Δ *Carryforward flag
differential 12.27% <0.00%> (?)
total 15.30% <ø> (+<0.01%) ⬆️ Carriedforward from 90d5b94

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit e6b41a8 into autowarefoundation:main Dec 18, 2023
34 of 36 checks passed
@takayuki5168 takayuki5168 deleted the chore/launch-behavior-vel-deug branch December 18, 2023 12:58
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@takayuki5168 @karishma1911
chore(behavior_velocity_planner): use DEBUG for launching modules (au…
5c20e3b 
…towarefoundation#5897)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@takayuki5168 @karishma1911
chore(behavior_velocity_planner): use DEBUG for launching modules (au…
9638706 
…towarefoundation#5897)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023
Merged
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@takayuki5168 @karishma1911
chore(behavior_velocity_planner): use DEBUG for launching modules (au…
ca75a28 
…towarefoundation#5897)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@takayuki5168 @karishma1911
chore(behavior_velocity_planner): use DEBUG for launching modules (au…
7f49e67 
…towarefoundation#5897)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@takayuki5168 @karishma1911
chore(behavior_velocity_planner): use DEBUG for launching modules (au…
3736608 
…towarefoundation#5897)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi

@soblin soblin Awaiting requested review from soblin

@shmpwk shmpwk Awaiting requested review from shmpwk

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees

@rej55 rej55

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takayuki5168 @rej55