Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(planning_debug_tools): improve calculation time of perception_reproducer #5894

Merged
merged 1 commit into from
Dec 18, 2023

perf(planning_debug_tools): improve calculation time of perception_re…

73834d1
Select commit
Loading
Failed to load commit list.
Merged

perf(planning_debug_tools): improve calculation time of perception_reproducer #5894

perf(planning_debug_tools): improve calculation time of perception_re…
73834d1
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 18, 2023 in 42s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method perception_reproducer.py: PerceptionReproducer.on_timer

Annotations

Check warning on line 94 in planning/planning_debug_tools/scripts/perception_replayer/perception_reproducer.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

PerceptionReproducer.on_timer increases in cyclomatic complexity from 12 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis