-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(avoidance_by_lane_change): update execution condition #5869
refactor(avoidance_by_lane_change): update execution condition #5869
Conversation
2147884
to
3147a9e
Compare
67e9029
to
a7c81dc
Compare
a7c81dc
to
5dfee2e
Compare
planning/behavior_path_avoidance_module/include/behavior_path_avoidance_module/helper.hpp
Outdated
Show resolved
Hide resolved
...g/behavior_path_avoidance_module/include/behavior_path_avoidance_module/parameter_helper.hpp
Outdated
Show resolved
Hide resolved
5dfee2e
to
02411db
Compare
bb4142f
to
ae6c037
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…avoidance_module/parameter_helper.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
ae6c037
to
9b9f497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I confirmed that normal LC was kicked and AbLC was launched instead.
simplescreenrecorder-2023-12-19_13.40.13.mp4
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5869 +/- ##
=======================================
Coverage 15.29% 15.29%
=======================================
Files 1747 1748 +1
Lines 120208 120239 +31
Branches 36631 36648 +17
=======================================
+ Hits 18383 18393 +10
- Misses 81207 81221 +14
- Partials 20618 20625 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c9b9fca
into
autowarefoundation:main
…arefoundation#5869) * refactor(avoidance_by_lane_change): update execution condition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix lc parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix both lane change and avoidance by lane change both are running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * trying to set maximum_avoid_distance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix avoidance param not properly assigned Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fixed avoidance not running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix root lanelet Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed gdb Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix unnecessary changes Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_avoidance_module/include/behavior_path_avoidance_module/parameter_helper.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Signed-off-by: karishma <karishma@interpl.ai>
…arefoundation#5869) * refactor(avoidance_by_lane_change): update execution condition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix lc parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix both lane change and avoidance by lane change both are running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * trying to set maximum_avoid_distance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix avoidance param not properly assigned Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fixed avoidance not running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix root lanelet Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed gdb Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix unnecessary changes Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_avoidance_module/include/behavior_path_avoidance_module/parameter_helper.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…arefoundation#5869) * refactor(avoidance_by_lane_change): update execution condition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix lc parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix both lane change and avoidance by lane change both are running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * trying to set maximum_avoid_distance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix avoidance param not properly assigned Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fixed avoidance not running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix root lanelet Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed gdb Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix unnecessary changes Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_avoidance_module/include/behavior_path_avoidance_module/parameter_helper.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Signed-off-by: karishma <karishma@interpl.ai>
…arefoundation#5869) * refactor(avoidance_by_lane_change): update execution condition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix lc parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix both lane change and avoidance by lane change both are running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * trying to set maximum_avoid_distance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix avoidance param not properly assigned Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fixed avoidance not running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix root lanelet Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed gdb Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix unnecessary changes Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_avoidance_module/include/behavior_path_avoidance_module/parameter_helper.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…arefoundation#5869) * refactor(avoidance_by_lane_change): update execution condition Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix lc parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix both lane change and avoidance by lane change both are running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * trying to set maximum_avoid_distance Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix avoidance param not properly assigned Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fixed avoidance not running Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix root lanelet Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * removed gdb Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * add debug Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix unnecessary changes Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_avoidance_module/include/behavior_path_avoidance_module/parameter_helper.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Description
🤖[deprecated] Generated by Copilot at 2147884
This pull request improves the lane change module for path avoidance by simplifying the logic, adding more flexibility, and enhancing the logging. It refactors the
specialRequiredCheck
function inscene.cpp
, extends thelane_change::utils
functions inutils.cpp
, adds a newprocessOnEntry
function ininterface.hpp
andinterface.cpp
, and modifies the logger name inbase_class.hpp
.Related links
None
Tests performed
PSIM and evaluator
Notes for reviewers
None
Interface changes
Avoidance by lane change has higher priorities, so if previously, in the case where obstacle + lane change module is activated, now avoidance by lane change will be activated instead.
Effects on system behavior
Avoidance by lane change has higher priorities, so if previously, in the case where obstacle + lane change module is activated, now avoidance by lane change will be activated instead.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.